-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: CI Refactor #1003
chore: CI Refactor #1003
Conversation
c37f286
to
59eff54
Compare
0e654a0
to
01a50da
Compare
Remaining flakes:
|
Can't yet add Node 22 to the build matrix due to nodejs/node#52682. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. I didn't have any blocking comments.
.github/workflows/ci.yml
Outdated
prefix-key: corebridge-buildcache | ||
shared-key: ${{ matrix.platform }} | ||
env-vars: '' | ||
# save-if: ${{ env.IS_MAIN_BRANCH }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I will uncoment this at the very last moment. Added a FIXME.
Cache space is limited, and rust build cache can take a lot of space. I want to avoid cache trashing due to PRs that make several successive modifications to the native code.
So the idea here is to keep the rust build cache reflecting the main branch as much as possible.
repository: temporalio/docker-compose | ||
path: docker-compose | ||
- name: Install Temporal CLI | ||
uses: temporalio/setup-temporal@v0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this action even stable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was about a year ago, and I'm not aware of any problem with it ATM. It goes through https://temporal.download/cli/
, not the shell script, and clearly, still work properly now that CLI 0.12.0 has been released.
But agree we should get some more pair of eyes on that repo.
What changed
action/artifacts@v1
and@v2
commands, which will soon no longer be supported by GitHub.TESTS_CLI_VERSION
andTESTS_TIME_SKIPPING_SERVER_VERSION
environment variables.