Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Nexus evaluate docs #3204

Merged
merged 11 commits into from
Nov 13, 2024
Merged

update Nexus evaluate docs #3204

merged 11 commits into from
Nov 13, 2024

Conversation

prasek
Copy link
Contributor

@prasek prasek commented Nov 8, 2024

What does this PR do?

  • Updates Nexus evaluate docs to incorporate feedback.

Notes to reviewers

Split out from #3196 where this has already been reviewed.

@prasek prasek requested a review from a team as a code owner November 8, 2024 15:31
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some repetition and unclear boundary between the points mentioned in "key features", "common use cases", and "advantages".

This is already pretty good though AFAIC. Feel free to keep massaging or merge as is.


Temporal Nexus provides an integrated Temporal SDK experience, built-in Nexus Machinery, first-class observability, and enables each team to have their own Namespace for improved security, troubleshooting, and blast radius isolation.
It allows multiple teams to collaborate autonomously while maintaining a clean separation of concerns, ensuring that applications are scalable, secure, and easy to manage as they grow.
- Reliably connect Temporal Applications within and across Namespaces.
Copy link
Contributor

@jsundai jsundai Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the update to the intro but this content looks like the same as the content currently on https://docs.temporal.io/cloud/nexus. I'm wondering what's the purpose of adding it to the Evaluate section? Usually we like to keep the Evaluate pages short and to the point since developers at various stages are clicking on this page.

Copy link
Contributor Author

@prasek prasek Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content in https://docs.temporal.io/cloud/nexus is evaluate content, so moved that here and refined it. There's a follow-on PR #3196 that reorganizes https://docs.temporal.io/cloud/nexus and removes the duplicate content, and links to the common evaluate content shared by cloud and self-hosted.

@prasek
Copy link
Contributor Author

prasek commented Nov 13, 2024

All feedback has been incorporated. Think we're good to go but would appreciate any final copy edits!

Signed-off-by: Phil Prasek <[email protected]>
Signed-off-by: Phil Prasek <[email protected]>
It allows multiple teams to collaborate autonomously while maintaining a clean separation of concerns, ensuring that applications are scalable, secure, and easy to manage as they grow.
- **Enhanced security and connectivity** \-
Temporal Cloud provides integrated Nexus access controls and multi-region routing.
- Connect Applications across Namespaces in an Account with Temporal's private mTLS-secured Envoy mesh.
Copy link
Contributor

@jsundai jsundai Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and love to see this updated version! One small nit. Please make sure to search through the file for "Worker" and capitalize it. Other than that, looks good to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsundai -- fixes are in, think we're good to go! 👍

@napcs napcs merged commit b348a75 into temporalio:main Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants