EDU-3394: How to mock Nexus operations in Go SDK #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Oct 31, 2024
bergundy
reviewed
Oct 31, 2024
|
Thank you for letting me have a look at this. I left non-blocking comments only. Since we don't have a well-defined process in-place yet, I would highly recommend fixing the lower-cased Workflows for compliance. Other comments were from a readability viewpoint about the content, with a few stray remarks about style standards. I'm really excited about seeing the Nexus material move into place. Thank you for all your work on this feature. |
fairlydurable
changed the title
fairlydurable
changed the title
bergundy
reviewed
Nov 1, 2024
bergundy
reviewed
Nov 1, 2024
bergundy
reviewed
Nov 1, 2024
bergundy
reviewed
Nov 1, 2024
Co-authored-by: Roey Berman <[email protected]>
|
Going ahead and unblocking this so it can be merged. Docs standards can be adopted in follow-up tickets. |
fairlydurable
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add docs to how to mock Nexus operation in Go SDK
Notes to reviewers