add slack link in evaluate nexus #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Sep 18, 2024
docs/evaluate/development-production-features/temporal-nexus.mdx
Outdated
Show resolved
Hide resolved
fairlydurable
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Unblocking this PR for timely updates.
Questions to consider:
- The last part of the conversation was "As discussed on slack let's change /temporalnexus* to /nexus* and what's now at /nexus to /evaluate/nexus." and it is still /temporalnexus. I do not see a comment that explains why the review feedback was marked as resolved without an explanation in the record as to why it was resolved.
- Why does one Slack link use the shortcut and one does not?
- Why is Encyclopedia capitalized in the link? Also, "entry" is more common than "section" for Encyclopedia content.
|
Just to update, this was resolved through slack convos and a previous PR merged. The Slack invite link is one that we'll need to monitor in case it changes. Thank you, @fairlydurable for the approval on short notice! Hoping to get your eyes on this project later down the line once style reviews happen and get your expertise. 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Notes to reviewers