Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overhaul dev guide indices, titles, tags #3088

Merged
merged 12 commits into from
Oct 1, 2024
Merged

overhaul dev guide indices, titles, tags #3088

merged 12 commits into from
Oct 1, 2024

Conversation

napcs
Copy link
Contributor

@napcs napcs commented Sep 16, 2024

  • Change Feature Guide to developer guide
  • Get titles consistent - drop "feature guide" and "temporal" from pages, normalize the rest of the titles.
  • Combine Python Cancellation and Interrupting Workflows pages into one page like the other gudies
  • Update tags where appropriate

@napcs napcs requested a review from a team as a code owner September 16, 2024 19:22
Copy link
Contributor

@fairlydurable fairlydurable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass was not deep: trying to find user-facing errors or pain points in updated material.

Pulled out diffs and ran through spell checker and grammar checker.

Then did visual inspection of files, much of which was rote.

docs/develop/dotnet/index.mdx Outdated Show resolved Hide resolved
docs/develop/typescript/observability.mdx Outdated Show resolved Hide resolved
docs/develop/dotnet/index.mdx Outdated Show resolved Hide resolved
docs/develop/go/index.mdx Outdated Show resolved Hide resolved
docs/develop/dotnet/asynchronous-activity.mdx Outdated Show resolved Hide resolved
docs/develop/go/observability.mdx Outdated Show resolved Hide resolved
docs/develop/go/timers.mdx Outdated Show resolved Hide resolved
docs/develop/java/index.mdx Outdated Show resolved Hide resolved
docs/develop/python/index.mdx Outdated Show resolved Hide resolved
docs/develop/typescript/entity-pattern.mdx Outdated Show resolved Hide resolved
docs/develop/php/index.mdx Outdated Show resolved Hide resolved
docs/develop/php/index.mdx Outdated Show resolved Hide resolved
@jsundai
Copy link
Contributor

jsundai commented Sep 30, 2024

LGTM. This looks fantastic!

napcs and others added 2 commits October 1, 2024 13:43
@napcs napcs merged commit 17d6d04 into main Oct 1, 2024
3 checks passed
@napcs napcs deleted the devguide-title-cleanup branch October 1, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants