-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overhaul dev guide indices, titles, tags #3088
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
napcs
commented
Sep 16, 2024
- Change Feature Guide to developer guide
- Get titles consistent - drop "feature guide" and "temporal" from pages, normalize the rest of the titles.
- Combine Python Cancellation and Interrupting Workflows pages into one page like the other gudies
- Update tags where appropriate
fairlydurable
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass was not deep: trying to find user-facing errors or pain points in updated material.
Pulled out diffs and ran through spell checker and grammar checker.
Then did visual inspection of files, much of which was rote.
napcs
commented
Sep 16, 2024
Co-authored-by: Erica Sadun <[email protected]>
Co-authored-by: Erica Sadun <[email protected]>
Co-authored-by: Erica Sadun <[email protected]>
jsundai
approved these changes
Sep 30, 2024
jsundai
reviewed
Sep 30, 2024
jsundai
reviewed
Sep 30, 2024
LGTM. This looks fantastic! |
Co-authored-by: Jwahir Sundai <[email protected]>
Co-authored-by: Jwahir Sundai <[email protected]>
fairlydurable
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.