Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for status_file in put #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phil9909
Copy link

@phil9909 phil9909 commented Feb 9, 2022

There are two ways of providing comments to the put step: comment and comment_file. The first one can be used for hard-coded comments while the later can be used for dynamically generated comments.
Dynamically generating the status is not possible. It can only be set via the status option.
Similar to the comment_file this PR adds an status_file option.

Use case: I execute unit-tests in the PR validation. If the creator of the PR made a mistake and therefore made the unit-tests fail, I don't want to have a red pipeline. For me, as a maintainer of the pipeline, everything works as intended. A red pipeline should indicate "something went wrong" (timeouts, missing permission to access GitHub, etc.), but actually the validation successfully detected a problem in the PR and successfully reported this back to GitHub.

@phil9909 phil9909 requested a review from a team as a code owner February 9, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant