New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added tooltip and scale-icon in data-grid button #2291
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for marvelous-moxie-a6e2fe failed.
|
Thanks for the PR! There are some build errors. Would you please have a look and fix them? |
@maomaoZH I have pushed the committed changes. There were some checks executed first time i created the pull request e.g. prettier, visual tests etc. Now I made some changes and pushed new commits to this pull request. Could you please let me know how these checks can be executed again in order to say now everything is ok? |
@acstll @felix-ico Could you please approve for the pipeline to run or do I need to do anything in order for pipelines to run? |
packages/components/tsconfig.json
Outdated
@@ -11,7 +11,8 @@ | |||
"noUnusedLocals": true, | |||
"noUnusedParameters": true, | |||
"jsx": "react", | |||
"jsxFactory": "h" | |||
"jsxFactory": "h", | |||
"skipLibCheck": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this required?
HI @sameetah looks like |
@acstll @felix-ico I have addressed the issues mentioned. |
@sameetah the uncommited-changes job is still failing, could you make sure that all files have been commmited? also, could you check if it's possible to remove the |
@felix-ico I removed the skipLibCheck rule in tsconfig file. Could you please have a look and see if checks pass now? |
@felix-ico The uncommitted changes are a single read me that is auto generated during the build process. All my changes are committed when I push so how do I account for the build script? |
@sameetah the build process should be the same locally and on CI, perhaps you commited something that is not part of this task (I wonder why the readme for chart-stack-card changes, when you have touched no code there) also comparing to the PR i opened, you can see a lot less files are committed...perhaps they are leftovers from previous code changes? |
61eebe1
to
85ea6e6
Compare
@felix-ico Could you please now check if the uncommitted changes check is passing? I made some changes and this should hopefully work |
@sameetah now you need to run |
@felix-ico Could you please check again if the checks pass this time? |
This feauture implements extension for the data-grid action cells to add tooltip and icons to the configured rows. This addresses the Issue 2236 that requested such feature. The tooltip and icons use the existing icon and tooltip feature from the scale button.
Reviews are appreciated.