Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added tooltip and scale-icon in data-grid button #2291

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sameetah
Copy link

@sameetah sameetah commented Mar 1, 2024

This feauture implements extension for the data-grid action cells to add tooltip and icons to the configured rows. This addresses the Issue 2236 that requested such feature. The tooltip and icons use the existing icon and tooltip feature from the scale button.
Reviews are appreciated.

Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for marvelous-moxie-a6e2fe failed.

Name Link
🔨 Latest commit 2dc9de0
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/6613bb1a066a9a0008423799

@maomaoZH
Copy link
Collaborator

maomaoZH commented Mar 4, 2024

Thanks for the PR! There are some build errors. Would you please have a look and fix them?

@sameetah
Copy link
Author

@maomaoZH I have pushed the committed changes. There were some checks executed first time i created the pull request e.g. prettier, visual tests etc. Now I made some changes and pushed new commits to this pull request. Could you please let me know how these checks can be executed again in order to say now everything is ok?

@sameetah
Copy link
Author

@acstll @felix-ico Could you please approve for the pipeline to run or do I need to do anything in order for pipelines to run?

@@ -11,7 +11,8 @@
"noUnusedLocals": true,
"noUnusedParameters": true,
"jsx": "react",
"jsxFactory": "h"
"jsxFactory": "h",
"skipLibCheck": true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this required?

@felix-ico
Copy link
Collaborator

HI @sameetah looks like build-pr / prettier and build-pr / uncommitted-changes are still failing. To fix the first one you should run yarn format and commit the changes, for the second one yarn build and commit the changes. build-pr / visual-tests (pull_request) should be OK to ignore, if there have been no visual changes in the components

@sameetah
Copy link
Author

sameetah commented Apr 3, 2024

@acstll @felix-ico I have addressed the issues mentioned.
For the 'build-pr/prettier' error, I ran 'yarn format' locally and committed the changes.
For the 'build-pr/uncommitted-changes' error, I ran 'yarn build' locally and committed the changes.
The changes have been pushed to the branch. Could you please review again? Thank you!

@felix-ico
Copy link
Collaborator

@sameetah the uncommited-changes job is still failing, could you make sure that all files have been commmited?
Screenshot 2024-04-03 at 14 05 09

also, could you check if it's possible to remove the skipLibCheck you added?

@felix-ico
Copy link
Collaborator

@sameetah I copied your changes in a separate branch, and removed that tsconfig rule, all checks seem to pass there...#2308

@sameetah
Copy link
Author

sameetah commented Apr 4, 2024

@felix-ico I removed the skipLibCheck rule in tsconfig file. Could you please have a look and see if checks pass now?

@sameetah
Copy link
Author

sameetah commented Apr 4, 2024

@felix-ico The uncommitted changes are a single read me that is auto generated during the build process. All my changes are committed when I push so how do I account for the build script?

@felix-ico
Copy link
Collaborator

@sameetah the build process should be the same locally and on CI, perhaps you commited something that is not part of this task (I wonder why the readme for chart-stack-card changes, when you have touched no code there) also comparing to the PR i opened, you can see a lot less files are committed...perhaps they are leftovers from previous code changes?

@sameetah
Copy link
Author

sameetah commented Apr 5, 2024

@felix-ico Could you please now check if the uncommitted changes check is passing? I made some changes and this should hopefully work

@felix-ico
Copy link
Collaborator

@sameetah now you need to run yarn format and yarn build in packages/components again...

@sameetah
Copy link
Author

sameetah commented Apr 8, 2024

@felix-ico Could you please check again if the checks pass this time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants