Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP0152 - Complete V1 conformance test suite #7913

Merged
merged 5 commits into from
May 29, 2024

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Apr 25, 2024

Changes

This PR consists of the V1 REQUIRED fields for v1 conformance.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 25, 2024
@JeromeJu JeromeJu added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Apr 25, 2024
@JeromeJu JeromeJu changed the title TEP0152 - Add V1 conformance test suite TEP0152 - Complete V1 conformance test suite Apr 25, 2024
@chitrangpatel chitrangpatel added this to the Pipeline v0.60 milestone Apr 30, 2024
@chitrangpatel
Copy link
Member

For clarity and easy to read, I would suggest moving the yamls to individual files under testdata folder or something.
And then add something that reads those yamls and runs the test. That would make it easy to parse and read (atleast to know which cases we have covered) and add more tests in the future.

@chitrangpatel
Copy link
Member

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@JeromeJu
Copy link
Member Author

JeromeJu commented May 9, 2024

For clarity and easy to read, I would suggest moving the yamls to individual files under testdata folder or something. And then add something that reads those yamls and runs the test. That would make it easy to parse and read (atleast to know which cases we have covered) and add more tests in the future.

Adding some outputs for the offline discussion we had - this is not done as fof the case of this PR mainly because we are having customized inputs for the YAML (which, potentially, could cause invalid YAML error with '%s' inputs in the files if we separate them out in different files).

cc @tektoncd/core-maintainers @tektoncd/core-collaborators PTAL 🙏

@JeromeJu
Copy link
Member Author

cc @tektoncd/core-maintainers can i have a lgtm?

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chitrangpatel,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit ba287f5 into tektoncd:main May 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants