skopeo-copy: add ability to pass parameters and copy manifests #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
tekton-robot
added
the
needs-ok-to-test
|
Hi @simbelmas. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
size/L
Diff between version 0.2 and 0.3diff --git a/task/skopeo-copy/0.2/README.md b/task/skopeo-copy/0.3/README.md
index 46953a9..dfeee51 100644
--- a/task/skopeo-copy/0.2/README.md
+++ b/task/skopeo-copy/0.3/README.md
@@ -75,6 +75,12 @@ docker://quay.io/temp/kubeconfigwriter:v1 docker://quay.io/skopeotest/kube:v1
docker://quay.io/temp/kubeconfigwriter:v2 docker://quay.io/skopeotest/kube:v2
```
+Each copy can be customized by adding *skopeo copy* parameters before images transport.
+
+```
+--all docker://quay.io/temp/kubeconfigwriter:v1 docker://quay.io/skopeotest/kube:v1
+```
+
`ConfigMap` should be created using this file. Following `command` can be used to create configMap from the `file`.
```
kubectl create configmap image-configmap --from-file=url.txt
diff --git a/task/skopeo-copy/0.2/skopeo-copy.yaml b/task/skopeo-copy/0.3/skopeo-copy.yaml
index 978930a..d7d5865 100644
--- a/task/skopeo-copy/0.2/skopeo-copy.yaml
+++ b/task/skopeo-copy/0.3/skopeo-copy.yaml
@@ -3,7 +3,7 @@ kind: Task
metadata:
name: skopeo-copy
labels:
- app.kubernetes.io/version: "0.2"
+ app.kubernetes.io/version: "0.3"
annotations:
tekton.dev/pipelines.minVersion: "0.12.1"
tekton.dev/categories: CLI
@@ -45,22 +45,18 @@ spec:
- name: HOME
value: /tekton/home
image: quay.io/skopeo/stable:v1.9.0
+ imagePullPolicy: IfNotPresent
script: |
# Function to copy multiple images.
#
copyimages() {
filename="$(workspaces.images-url.path)/url.txt"
- while IFS= read -r line || [ -n "$line" ]
+ while read -r line || [ -n "$line" ]
do
- cmd=""
- for url in $line
- do
- # echo $url
- cmd="$cmd \
- $url"
- done
- skopeo copy "$cmd" --src-tls-verify="$(params.srcTLSverify)" --dest-tls-verify="$(params.destTLSverify)"
- echo "$cmd"
+ (
+ set +x
+ skopeo copy $line --src-tls-verify="$(params.srcTLSverify)" --dest-tls-verify="$(params.destTLSverify)"
+ )
done < "$filename"
}
# |
Catlin OutputCatlin script lint Output |
Diff between version 0.2 and 0.3diff --git a/task/skopeo-copy/0.2/README.md b/task/skopeo-copy/0.3/README.md
index 46953a9..dfeee51 100644
--- a/task/skopeo-copy/0.2/README.md
+++ b/task/skopeo-copy/0.3/README.md
@@ -75,6 +75,12 @@ docker://quay.io/temp/kubeconfigwriter:v1 docker://quay.io/skopeotest/kube:v1
docker://quay.io/temp/kubeconfigwriter:v2 docker://quay.io/skopeotest/kube:v2
```
+Each copy can be customized by adding *skopeo copy* parameters before images transport.
+
+```
+--all docker://quay.io/temp/kubeconfigwriter:v1 docker://quay.io/skopeotest/kube:v1
+```
+
`ConfigMap` should be created using this file. Following `command` can be used to create configMap from the `file`.
```
kubectl create configmap image-configmap --from-file=url.txt
diff --git a/task/skopeo-copy/0.2/skopeo-copy.yaml b/task/skopeo-copy/0.3/skopeo-copy.yaml
index 978930a..681031c 100644
--- a/task/skopeo-copy/0.2/skopeo-copy.yaml
+++ b/task/skopeo-copy/0.3/skopeo-copy.yaml
@@ -3,7 +3,7 @@ kind: Task
metadata:
name: skopeo-copy
labels:
- app.kubernetes.io/version: "0.2"
+ app.kubernetes.io/version: "0.3"
annotations:
tekton.dev/pipelines.minVersion: "0.12.1"
tekton.dev/categories: CLI
@@ -45,22 +45,18 @@ spec:
- name: HOME
value: /tekton/home
image: quay.io/skopeo/stable:v1.9.0
+ imagePullPolicy: IfNotPresent
script: |
# Function to copy multiple images.
#
copyimages() {
filename="$(workspaces.images-url.path)/url.txt"
- while IFS= read -r line || [ -n "$line" ]
+ while read -r line || [ -n "$line" ]
do
- cmd=""
- for url in $line
- do
- # echo $url
- cmd="$cmd \
- $url"
- done
- skopeo copy "$cmd" --src-tls-verify="$(params.srcTLSverify)" --dest-tls-verify="$(params.destTLSverify)"
- echo "$cmd"
+ (
+ set -x
+ skopeo copy $line --src-tls-verify="$(params.srcTLSverify)" --dest-tls-verify="$(params.destTLSverify)"
+ )
done < "$filename"
}
# |
Catlin OutputCatlin script lint Output |
|
/ok-to-test |
tekton-robot
added
ok-to-test
|
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
tekton-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
tekton-robot
added
lifecycle/rotten
vinamra28
reviewed
May 22, 2023
|
/remove-lifecycle rotten |
tekton-robot
removed
the
lifecycle/rotten
|
i'm looking forwards to this. There is a current bug in the version 0.2 of this task where if u provide it with a |
Catlin OutputCatlin script lint Output |
1 similar comment
Catlin OutputCatlin script lint Output |
Co-authored-by: Vinamra Jain <[email protected]>
Co-authored-by: Vinamra Jain <[email protected]>
Co-authored-by: Vinamra Jain <[email protected]>
Co-authored-by: Vinamra Jain <[email protected]>
Catlin OutputCatlin script lint Output |
Diff between version 0.2 and 0.3diff --git a/task/skopeo-copy/0.2/README.md b/task/skopeo-copy/0.3/README.md
index 46953a9..e222862 100644
--- a/task/skopeo-copy/0.2/README.md
+++ b/task/skopeo-copy/0.3/README.md
@@ -39,7 +39,7 @@ This `task` can be used to copy one or more than one images to-and fro various s
## Install the Task
```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/skopeo-copy/0.2/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/skopeo-copy/0.3/raw
```
## Parameters
@@ -58,7 +58,7 @@ kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/skopeo-copy/
* `Secret` to provide the credentials of the source and destination registry where the image needs to be copied from and to.
* `ConfigMap` to provide support for copying multiple images, this contains file `url.txt` which stores images registry URL's.
- [This](../0.2/samples/quay-secret.yaml) example can help to use secrets for providing credentials of image registries.
+ [This](../0.3/samples/quay-secret.yaml) example can help to use secrets for providing credentials of image registries.
## Platforms
@@ -75,6 +75,12 @@ docker://quay.io/temp/kubeconfigwriter:v1 docker://quay.io/skopeotest/kube:v1
docker://quay.io/temp/kubeconfigwriter:v2 docker://quay.io/skopeotest/kube:v2
```
+Each copy can be customized by adding *skopeo copy* parameters before images transport.
+
+```
+--all docker://quay.io/temp/kubeconfigwriter:v1 docker://quay.io/skopeotest/kube:v1
+```
+
`ConfigMap` should be created using this file. Following `command` can be used to create configMap from the `file`.
```
kubectl create configmap image-configmap --from-file=url.txt
@@ -84,9 +90,9 @@ In case there is only one source and destination image that needs to be copied t
This will result in the image getting copied from the source registry to the destination registry.
-[This](../0.2/samples/serviceaccount.yaml) will guide the user to use service account for authorization to image registries.
+[This](../0.3/samples/serviceaccount.yaml) will guide the user to use service account for authorization to image registries.
-See [here](../0.2/samples/run.yaml) for example of `TaskRun`.
+See [here](../0.3/samples/run.yaml) for example of `TaskRun`.
### Note
- `Source credentials` are only required, if the source image registry needs authentication to pull the image, whereas `Destination credentials` are always required.
diff --git a/task/skopeo-copy/0.2/skopeo-copy.yaml b/task/skopeo-copy/0.3/skopeo-copy.yaml
index 978930a..681031c 100644
--- a/task/skopeo-copy/0.2/skopeo-copy.yaml
+++ b/task/skopeo-copy/0.3/skopeo-copy.yaml
@@ -3,7 +3,7 @@ kind: Task
metadata:
name: skopeo-copy
labels:
- app.kubernetes.io/version: "0.2"
+ app.kubernetes.io/version: "0.3"
annotations:
tekton.dev/pipelines.minVersion: "0.12.1"
tekton.dev/categories: CLI
@@ -45,22 +45,18 @@ spec:
- name: HOME
value: /tekton/home
image: quay.io/skopeo/stable:v1.9.0
+ imagePullPolicy: IfNotPresent
script: |
# Function to copy multiple images.
#
copyimages() {
filename="$(workspaces.images-url.path)/url.txt"
- while IFS= read -r line || [ -n "$line" ]
+ while read -r line || [ -n "$line" ]
do
- cmd=""
- for url in $line
- do
- # echo $url
- cmd="$cmd \
- $url"
- done
- skopeo copy "$cmd" --src-tls-verify="$(params.srcTLSverify)" --dest-tls-verify="$(params.destTLSverify)"
- echo "$cmd"
+ (
+ set -x
+ skopeo copy $line --src-tls-verify="$(params.srcTLSverify)" --dest-tls-verify="$(params.destTLSverify)"
+ )
done < "$filename"
}
# |
Catlin OutputCatlin script lint Output |
Diff between version 0.2 and 0.3diff --git a/task/skopeo-copy/0.2/README.md b/task/skopeo-copy/0.3/README.md
index 46953a9..e222862 100644
--- a/task/skopeo-copy/0.2/README.md
+++ b/task/skopeo-copy/0.3/README.md
@@ -39,7 +39,7 @@ This `task` can be used to copy one or more than one images to-and fro various s
## Install the Task
```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/skopeo-copy/0.2/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/skopeo-copy/0.3/raw
```
## Parameters
@@ -58,7 +58,7 @@ kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/skopeo-copy/
* `Secret` to provide the credentials of the source and destination registry where the image needs to be copied from and to.
* `ConfigMap` to provide support for copying multiple images, this contains file `url.txt` which stores images registry URL's.
- [This](../0.2/samples/quay-secret.yaml) example can help to use secrets for providing credentials of image registries.
+ [This](../0.3/samples/quay-secret.yaml) example can help to use secrets for providing credentials of image registries.
## Platforms
@@ -75,6 +75,12 @@ docker://quay.io/temp/kubeconfigwriter:v1 docker://quay.io/skopeotest/kube:v1
docker://quay.io/temp/kubeconfigwriter:v2 docker://quay.io/skopeotest/kube:v2
```
+Each copy can be customized by adding *skopeo copy* parameters before images transport.
+
+```
+--all docker://quay.io/temp/kubeconfigwriter:v1 docker://quay.io/skopeotest/kube:v1
+```
+
`ConfigMap` should be created using this file. Following `command` can be used to create configMap from the `file`.
```
kubectl create configmap image-configmap --from-file=url.txt
@@ -84,9 +90,9 @@ In case there is only one source and destination image that needs to be copied t
This will result in the image getting copied from the source registry to the destination registry.
-[This](../0.2/samples/serviceaccount.yaml) will guide the user to use service account for authorization to image registries.
+[This](../0.3/samples/serviceaccount.yaml) will guide the user to use service account for authorization to image registries.
-See [here](../0.2/samples/run.yaml) for example of `TaskRun`.
+See [here](../0.3/samples/run.yaml) for example of `TaskRun`.
### Note
- `Source credentials` are only required, if the source image registry needs authentication to pull the image, whereas `Destination credentials` are always required.
diff --git a/task/skopeo-copy/0.2/skopeo-copy.yaml b/task/skopeo-copy/0.3/skopeo-copy.yaml
index 978930a..681031c 100644
--- a/task/skopeo-copy/0.2/skopeo-copy.yaml
+++ b/task/skopeo-copy/0.3/skopeo-copy.yaml
@@ -3,7 +3,7 @@ kind: Task
metadata:
name: skopeo-copy
labels:
- app.kubernetes.io/version: "0.2"
+ app.kubernetes.io/version: "0.3"
annotations:
tekton.dev/pipelines.minVersion: "0.12.1"
tekton.dev/categories: CLI
@@ -45,22 +45,18 @@ spec:
- name: HOME
value: /tekton/home
image: quay.io/skopeo/stable:v1.9.0
+ imagePullPolicy: IfNotPresent
script: |
# Function to copy multiple images.
#
copyimages() {
filename="$(workspaces.images-url.path)/url.txt"
- while IFS= read -r line || [ -n "$line" ]
+ while read -r line || [ -n "$line" ]
do
- cmd=""
- for url in $line
- do
- # echo $url
- cmd="$cmd \
- $url"
- done
- skopeo copy "$cmd" --src-tls-verify="$(params.srcTLSverify)" --dest-tls-verify="$(params.destTLSverify)"
- echo "$cmd"
+ (
+ set -x
+ skopeo copy $line --src-tls-verify="$(params.srcTLSverify)" --dest-tls-verify="$(params.destTLSverify)"
+ )
done < "$filename"
}
# |
1 similar comment
Diff between version 0.2 and 0.3diff --git a/task/skopeo-copy/0.2/README.md b/task/skopeo-copy/0.3/README.md
index 46953a9..e222862 100644
--- a/task/skopeo-copy/0.2/README.md
+++ b/task/skopeo-copy/0.3/README.md
@@ -39,7 +39,7 @@ This `task` can be used to copy one or more than one images to-and fro various s
## Install the Task
```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/skopeo-copy/0.2/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/skopeo-copy/0.3/raw
```
## Parameters
@@ -58,7 +58,7 @@ kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/skopeo-copy/
* `Secret` to provide the credentials of the source and destination registry where the image needs to be copied from and to.
* `ConfigMap` to provide support for copying multiple images, this contains file `url.txt` which stores images registry URL's.
- [This](../0.2/samples/quay-secret.yaml) example can help to use secrets for providing credentials of image registries.
+ [This](../0.3/samples/quay-secret.yaml) example can help to use secrets for providing credentials of image registries.
## Platforms
@@ -75,6 +75,12 @@ docker://quay.io/temp/kubeconfigwriter:v1 docker://quay.io/skopeotest/kube:v1
docker://quay.io/temp/kubeconfigwriter:v2 docker://quay.io/skopeotest/kube:v2
```
+Each copy can be customized by adding *skopeo copy* parameters before images transport.
+
+```
+--all docker://quay.io/temp/kubeconfigwriter:v1 docker://quay.io/skopeotest/kube:v1
+```
+
`ConfigMap` should be created using this file. Following `command` can be used to create configMap from the `file`.
```
kubectl create configmap image-configmap --from-file=url.txt
@@ -84,9 +90,9 @@ In case there is only one source and destination image that needs to be copied t
This will result in the image getting copied from the source registry to the destination registry.
-[This](../0.2/samples/serviceaccount.yaml) will guide the user to use service account for authorization to image registries.
+[This](../0.3/samples/serviceaccount.yaml) will guide the user to use service account for authorization to image registries.
-See [here](../0.2/samples/run.yaml) for example of `TaskRun`.
+See [here](../0.3/samples/run.yaml) for example of `TaskRun`.
### Note
- `Source credentials` are only required, if the source image registry needs authentication to pull the image, whereas `Destination credentials` are always required.
diff --git a/task/skopeo-copy/0.2/skopeo-copy.yaml b/task/skopeo-copy/0.3/skopeo-copy.yaml
index 978930a..681031c 100644
--- a/task/skopeo-copy/0.2/skopeo-copy.yaml
+++ b/task/skopeo-copy/0.3/skopeo-copy.yaml
@@ -3,7 +3,7 @@ kind: Task
metadata:
name: skopeo-copy
labels:
- app.kubernetes.io/version: "0.2"
+ app.kubernetes.io/version: "0.3"
annotations:
tekton.dev/pipelines.minVersion: "0.12.1"
tekton.dev/categories: CLI
@@ -45,22 +45,18 @@ spec:
- name: HOME
value: /tekton/home
image: quay.io/skopeo/stable:v1.9.0
+ imagePullPolicy: IfNotPresent
script: |
# Function to copy multiple images.
#
copyimages() {
filename="$(workspaces.images-url.path)/url.txt"
- while IFS= read -r line || [ -n "$line" ]
+ while read -r line || [ -n "$line" ]
do
- cmd=""
- for url in $line
- do
- # echo $url
- cmd="$cmd \
- $url"
- done
- skopeo copy "$cmd" --src-tls-verify="$(params.srcTLSverify)" --dest-tls-verify="$(params.destTLSverify)"
- echo "$cmd"
+ (
+ set -x
+ skopeo copy $line --src-tls-verify="$(params.srcTLSverify)" --dest-tls-verify="$(params.destTLSverify)"
+ )
done < "$filename"
}
# |
Catlin OutputCatlin script lint Output |
Diff between version 0.2 and 0.3diff --git a/task/skopeo-copy/0.2/README.md b/task/skopeo-copy/0.3/README.md
index 46953a9..e222862 100644
--- a/task/skopeo-copy/0.2/README.md
+++ b/task/skopeo-copy/0.3/README.md
@@ -39,7 +39,7 @@ This `task` can be used to copy one or more than one images to-and fro various s
## Install the Task
```
-kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/skopeo-copy/0.2/raw
+kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/skopeo-copy/0.3/raw
```
## Parameters
@@ -58,7 +58,7 @@ kubectl apply -f https://api.hub.tekton.dev/v1/resource/tekton/task/skopeo-copy/
* `Secret` to provide the credentials of the source and destination registry where the image needs to be copied from and to.
* `ConfigMap` to provide support for copying multiple images, this contains file `url.txt` which stores images registry URL's.
- [This](../0.2/samples/quay-secret.yaml) example can help to use secrets for providing credentials of image registries.
+ [This](../0.3/samples/quay-secret.yaml) example can help to use secrets for providing credentials of image registries.
## Platforms
@@ -75,6 +75,12 @@ docker://quay.io/temp/kubeconfigwriter:v1 docker://quay.io/skopeotest/kube:v1
docker://quay.io/temp/kubeconfigwriter:v2 docker://quay.io/skopeotest/kube:v2
```
+Each copy can be customized by adding *skopeo copy* parameters before images transport.
+
+```
+--all docker://quay.io/temp/kubeconfigwriter:v1 docker://quay.io/skopeotest/kube:v1
+```
+
`ConfigMap` should be created using this file. Following `command` can be used to create configMap from the `file`.
```
kubectl create configmap image-configmap --from-file=url.txt
@@ -84,9 +90,9 @@ In case there is only one source and destination image that needs to be copied t
This will result in the image getting copied from the source registry to the destination registry.
-[This](../0.2/samples/serviceaccount.yaml) will guide the user to use service account for authorization to image registries.
+[This](../0.3/samples/serviceaccount.yaml) will guide the user to use service account for authorization to image registries.
-See [here](../0.2/samples/run.yaml) for example of `TaskRun`.
+See [here](../0.3/samples/run.yaml) for example of `TaskRun`.
### Note
- `Source credentials` are only required, if the source image registry needs authentication to pull the image, whereas `Destination credentials` are always required.
diff --git a/task/skopeo-copy/0.2/skopeo-copy.yaml b/task/skopeo-copy/0.3/skopeo-copy.yaml
index 978930a..681031c 100644
--- a/task/skopeo-copy/0.2/skopeo-copy.yaml
+++ b/task/skopeo-copy/0.3/skopeo-copy.yaml
@@ -3,7 +3,7 @@ kind: Task
metadata:
name: skopeo-copy
labels:
- app.kubernetes.io/version: "0.2"
+ app.kubernetes.io/version: "0.3"
annotations:
tekton.dev/pipelines.minVersion: "0.12.1"
tekton.dev/categories: CLI
@@ -45,22 +45,18 @@ spec:
- name: HOME
value: /tekton/home
image: quay.io/skopeo/stable:v1.9.0
+ imagePullPolicy: IfNotPresent
script: |
# Function to copy multiple images.
#
copyimages() {
filename="$(workspaces.images-url.path)/url.txt"
- while IFS= read -r line || [ -n "$line" ]
+ while read -r line || [ -n "$line" ]
do
- cmd=""
- for url in $line
- do
- # echo $url
- cmd="$cmd \
- $url"
- done
- skopeo copy "$cmd" --src-tls-verify="$(params.srcTLSverify)" --dest-tls-verify="$(params.destTLSverify)"
- echo "$cmd"
+ (
+ set -x
+ skopeo copy $line --src-tls-verify="$(params.srcTLSverify)" --dest-tls-verify="$(params.destTLSverify)"
+ )
done < "$filename"
}
# |
Catlin OutputCatlin script lint Output |
vinamra28
reviewed
Jul 22, 2023
There was a problem hiding this comment.
@simbelmas thanks for addressing the comments. Can you please sign the CLA and also squash the commits into a single one?
tekton-robot
added
the
needs-rebase
|
@simbelmas: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add ability to pass parameters to skopeo copy command.
This allows to copy full manifests.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
contains
/kind <type>. Valid types are bug, cleanup, design, documentation,feature, flake, misc, question, tep
<kind>/<name>/<version>/name.yamlREADME.mdat<kind>/<name>/<version>/README.mdmetadata.labels-app.kubernetes.io/versionthe same as the<version>of the resourcemetadata.annotationstekton.dev/pipelines.minVersionspec.descriptionfollows the convention