Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the packit configuration #3374

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Simplify the packit configuration #3374

merged 1 commit into from
Dec 6, 2024

Conversation

LecrisUT
Copy link
Contributor

Follow-up to #3024 now that packit/packit#2378 is merged.

@LecrisUT LecrisUT force-pushed the simplify/packit branch 3 times, most recently from 7444b81 to 0563827 Compare November 21, 2024 13:41
@LecrisUT LecrisUT mentioned this pull request Nov 21, 2024
Merged
@LecrisUT
Copy link
Contributor Author

@martinhoyer can you /packit build this one?

@psss
Copy link
Collaborator

psss commented Nov 27, 2024

/packit build

@psss psss self-assigned this Dec 6, 2024
@psss psss added the packaging Changes related to the rpm packaging label Dec 6, 2024
@psss psss added this to the 1.40 milestone Dec 6, 2024
psss
psss approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying this! Looks good and the overall resulting config seems to be identical with the orignal one (except for some defaults, which is expected).

@psss psss added the ci | full test Pull request is ready for the full test execution label Dec 6, 2024
@psss
Copy link
Collaborator

psss commented Dec 6, 2024

/packit build

@psss psss changed the title Simplify packit configuration Simplify the packit configuration Dec 6, 2024
@psss psss merged commit cae4447 into teemtee:main Dec 6, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@martinhoyer martinhoyer martinhoyer approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@happz happz Awaiting requested review from happz happz is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution packaging Changes related to the rpm packaging
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.
3 participants
@LecrisUT @psss @martinhoyer