Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for multiple same checks per test #3332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add warning for multiple same checks per test #3332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tmt/checks/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import dataclasses
import enum
import functools
from collections import Counter
from typing import TYPE_CHECKING, Any, Callable, Generic, Optional, TypedDict, TypeVar, cast

import tmt.log
Expand Down Expand Up @@ -300,12 +301,20 @@ def normalize_test_checks(
# ignore[redundant-cast]: mypy infers the type to be `list[Any]` while
# pyright, not making assumptions about the type of items, settles for
# `list[Unknown]`. The `cast()` helps pyright, but mypy complains.
return [
checks = [
normalize_test_check(f'{key_address}[{i}]', raw_test_check, logger)
for i, raw_test_check in enumerate(
cast(list[Any], raw_checks)) # type: ignore[redundant-cast]
]

how_counts = Counter(check.how for check in checks)

for how, count in how_counts.items():
if count > 1:
logger.warning(f"Multiple {how} checks found")

return checks

raise tmt.utils.NormalizationError(
key_address,
raw_checks,
Expand Down
Loading