Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync the .packit.yaml config to downstream repo #269

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Sync the .packit.yaml config to downstream repo #269

merged 1 commit into from
Dec 4, 2024

Conversation

psss
Copy link
Collaborator

@psss psss commented Dec 4, 2024

The config file needs to be present in the rawhide branch of dist-git to actually enable the propose_downstream feature. Let's keep the file in sync.

@psss psss added this to the 1.6 milestone Dec 4, 2024
@psss psss requested a review from martinhoyer December 4, 2024 13:26
The config file needs to be present in the `rawhide` branch of
dist-git to actually enable the `propose_downstream` feature.
Let's keep the file in sync.
@psss psss changed the title Sync the.packit.yaml config to downstream repo Sync the .packit.yaml config to downstream repo Dec 4, 2024
@psss psss added the packaging label Dec 4, 2024
Copy link
Contributor

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember if it's the spec file or the packit config that is synced by default, but it's good to have them both explicitly

@psss
Copy link
Collaborator Author

psss commented Dec 4, 2024

I don't think there is any default value, packit docs state that only packit init would default for the two files:

Spec file path and config file path are always included by packit init but can be manually removed from the list.

@psss psss self-assigned this Dec 4, 2024
@psss psss merged commit c116ec3 into main Dec 4, 2024
12 of 13 checks passed
@psss psss deleted the synced-files branch December 4, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants