Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release fmf-1.5.0 #262

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Release fmf-1.5.0 #262

merged 2 commits into from
Dec 3, 2024

Conversation

psss
Copy link
Collaborator

@psss psss commented Dec 2, 2024

Follow the steps below to create a new major or minor release:

  • Update README.rst with new contributors since the last release
  • Review the release notes in releases.rst, update as needed
  • Add a Release x.y.z commit, empty if needed: git commit --allow-empty -m "Release x.y.z"
  • Create a pull request with the commit, ensure tests pass, merge it

Create a new github release based on the tag above

  • Move the fedora branch to point to the new release
  • Tag the commit with x.y.z, push tags git push --tags
  • Create a new github release based on the tag above
  • Mention the most important changes in the name, do not include version
  • Push the “Generate release notes” button to create the content
  • Publish the release, check Fedora pull requests, make sure tests pass and merge
  • Close the corresponding release milestone

@psss psss added this to the 1.5 milestone Dec 2, 2024
Copy link
Contributor

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks :) Thanks!

docs/releases.rst Outdated Show resolved Hide resolved
docs/releases.rst Outdated Show resolved Hide resolved
docs/releases.rst Outdated Show resolved Hide resolved
docs/releases.rst Show resolved Hide resolved
docs/releases.rst Outdated Show resolved Hide resolved
docs/releases.rst Show resolved Hide resolved
@psss psss self-assigned this Dec 3, 2024
@psss psss added the packaging label Dec 3, 2024
@psss psss merged commit bafb23a into main Dec 3, 2024
12 of 13 checks passed
@psss psss deleted the release-1.5.0 branch December 3, 2024 20:31
@psss
Copy link
Collaborator Author

psss commented Dec 3, 2024

So, the release action failed with:

pipx: error: argument command: invalid choice: 'hatch'

@LecrisUT, why pipx is used for running hatch build? Is the correct syntax pipx run hatch build?

@LecrisUT
Copy link
Contributor

LecrisUT commented Dec 3, 2024

I forgot I had it like that. pipx is just to avoid a pip install command. Should have replaced it with build-and-inspect-python-package and always run it.

Yes, the pipx run should have been there

@martinhoyer
Copy link
Contributor

I forgot I had it like that. pipx is just to avoid a pip install command. Should have replaced it with build-and-inspect-python-package and always run it.

Yes, the pipx run should have been there

This looks pretty good.

As for the pipx vs pip, etc...
Ultimately doesn't matter, especially since it's being run only on release. Also, depends on what's already available on ths image.

I wouldn't be afraid of just doing pip install hatch here. But yeah hynek's action looks cool.

Anyway, for 1.5.0 - manual hatch publish?

@psss
Copy link
Collaborator Author

psss commented Dec 4, 2024

There might be more surprises on the way, let's try the automation until the end. I've updated the command in #268 and will re-create the release again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants