php 8+ edge cases fixes #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@williamdes I am having a problem that is solved from this pull request (max function throwing an error because of the empty array). Can we except this to be merged to the main branch? |
edoniti
approved these changes
Jul 13, 2023
|
Hi @nicolaasuni |
Closed
|
Just encountered this issue for some our customers at Fixably too after upgrading to PHP8. I tested the changes from this PR and confirm it works on our end so it would be lovely if this PR could get reviewed and merged. I left an in-line review that also fixes another minor issue, that this PR doesn't fully resolve |
nicolaasuni
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with division by zero, returns from function pregSplit to match the expected, and calculates maximum width for a single character on the string will not throw an error when the variable is not countable