Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various improvements #400

Merged
merged 7 commits into from
Nov 10, 2024
Merged

various improvements #400

merged 7 commits into from
Nov 10, 2024

Conversation

philprime
Copy link
Member

  • chore(dev): add debug configuration toggle for macOS examples
  • chore: add annotation retroactive for NSEdgeInsets Equatable implementation

@philprime philprime self-assigned this Nov 10, 2024
@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

SwiftLint found issues

Severity File Reason
Warning DetailView.swift:6 Header comments should be consistent with project patterns. (file_header)
Warning CrossPlattformGraphics.swift:209 Closure body should span 20 lines or less excluding comments and whitespace: currently spans 25 lines (closure_body_length)

Generated by 🚫 Danger Swift against 7729d6f

@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

SwiftLint found issues

Severity File Reason
Warning DetailView.swift:6 Header comments should be consistent with project patterns. (file_header)
Warning CrossPlattformGraphics.swift:209 Closure body should span 20 lines or less excluding comments and whitespace: currently spans 25 lines (closure_body_length)

Generated by 🚫 Danger Swift against 717e797

@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ The Package.swift was updated, but there were no changes in TPPDF.podspec, Package.resolved. Did you forget to update them?
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

SwiftLint found issues

Severity File Reason
Warning Package.swift:10 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:13 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:17 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:24 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:26 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:31 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:33 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:34 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFContainer.swift:99 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFInfo.swift:101 Collection literals should not have trailing commas. (trailing_comma)
Warning DetailView.swift:6 Header comments should be consistent with project patterns. (file_header)
Warning PDFExternalPageObject.swift:24 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFContextGraphics.swift:67 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFGroupObject.swift:62 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFColumnLayoutState.swift:27 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFColumnLayoutState.swift:32 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFColumnLayoutState.swift:37 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFColumnLayoutState.swift:42 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFColumnLayoutState.swift:47 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFColumnLayoutState.swift:56 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFColumnLayoutState.swift:61 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFColumnLayoutState.swift:66 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFColumnLayoutState.swift:71 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFColumnLayoutState.swift:76 Collection literals should not have trailing commas. (trailing_comma)
Warning CrossPlattformGraphics.swift:209 Closure body should span 20 lines or less excluding comments and whitespace: currently spans 25 lines (closure_body_length)
Warning PDFGenerator+Generation.swift:332 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFSlicedObject.swift:26 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFSectionObject.swift:28 Function body should span 40 lines or less excluding comments and whitespace: currently spans 42 lines (function_body_length)
Warning PDFAttributedTextObject.swift:290 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFTableObject.swift:270 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFTableObject.swift:618 Collection literals should not have trailing commas. (trailing_comma)

Generated by 🚫 Danger Swift against fbbd3d8

@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ The Package.swift was updated, but there were no changes in TPPDF.podspec, Package.resolved. Did you forget to update them?
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

SwiftLint found issues

Severity File Reason
Warning DetailView.swift:6 Header comments should be consistent with project patterns. (file_header)
Warning CrossPlattformGraphics.swift:209 Closure body should span 20 lines or less excluding comments and whitespace: currently spans 25 lines (closure_body_length)
Warning PDFSectionObject.swift:28 Function body should span 40 lines or less excluding comments and whitespace: currently spans 42 lines (function_body_length)

Generated by 🚫 Danger Swift against e573642

@techprimate-bot
Copy link

Warnings
⚠️ The Package.swift was updated, but there were no changes in TPPDF.podspec, Package.resolved. Did you forget to update them?
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

SwiftLint found issues

Severity File Reason
Warning DetailView.swift:6 Header comments should be consistent with project patterns. (file_header)
Warning CrossPlattformGraphics.swift:209 Closure body should span 20 lines or less excluding comments and whitespace: currently spans 25 lines (closure_body_length)
Warning PDFSectionObject.swift:28 Function body should span 40 lines or less excluding comments and whitespace: currently spans 42 lines (function_body_length)

Generated by 🚫 Danger Swift against 3ab677f

@philprime philprime merged commit 3ab677f into main Nov 10, 2024
9 checks passed
@philprime philprime deleted the various-improvements branch November 10, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants