-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix table outline frame calculations; removed conditional rendering of outline #396
Conversation
Hi Jeff, thanks for opening up this pull request. I can confirm that the current example is not working as expected, and that your PR fixes it. I do have a couple of comments, I'll add to the review |
I'm not set up for iOS dev at the moment so I can't take a look at the failing tests, but I have thoroughly tested this on macOS and fixed one final bug with the final offsets. |
Thank you, I can take over looking at the tests for iOS and fix it in the upcoming days |
So I fixed the expected test results, they did not include the table outline to begin with. But it seems like there is something wrong in the CI, going to fix this on a different branch, I'll then update this PR |
alright looks like the checks are now passing. Anymore changes from your side? Otherwise, lgtm |
Amazing thank you! It's all working for me, let's merge! |
The
TableExampleFactory
creates tables with outline borders, but the outlines are never drawn. This fixes that.