-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds custom spacing to lists #352
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
=======================================
Coverage 78.86% 78.86%
=======================================
Files 212 212
Lines 12607 12617 +10
=======================================
+ Hits 9942 9950 +8
- Misses 2665 2667 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @icopano! Sorry for my super late response, busy times and this got lost in my inbox. Your implementation looks straight away, but I will adapt it slightly, so the |
Ok it looks like I can't push to your branch because of branch protections of the main branch (it's often easier to create a new branch after forking). Instead I pushed my recommended changes in the branch Commit with my changes: 730bcf3 |
Ping @icopano are you still interested in getting this merged? |
Hi Philip! Sorry just seen this, I'll have a look at this later this evening, if that's okey with you? Your comment makes sense, thanks for pointing it out! |
No worries, I also forgot about the PR :) Alright, looking forward to continue working on this! |
Added the possibility to setup a custom spacing to List.
I saw this in a closed issue which was never addressed and thought It would be a nice addition.
This implementation assumes the use of a constant spacing.