feat: session binding#2310
Open
lfleischmann wants to merge 8 commits into
Open
Conversation
This reverts commit e2afe2a.
lfleischmann
force-pushed
the
feat-session-binding
branch
from
e2afe2a to
130e606
Compare
| }, | ||
| Session: Session{ | ||
| Binding: Binding{ | ||
| Enabled: true, |
Contributor
There was a problem hiding this comment.
I think we should disable this by default, since this might cause problems, depending on the domain setup.
|
|
||
| // If we are here, we are initializing a flow. | ||
| // If we have a session for the given cookie, we simply use the existing session. | ||
| if sessionModel != nil { |
Contributor
There was a problem hiding this comment.
We should add a grace period here and should check how long the session is still valid and e.g. when it's only valid for 10 minutes, we should create a new session.
Member
Author
There was a problem hiding this comment.
Can you give a suggestion?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes add anonymous sessions and result in binding these anonymous sessions to flows.
Implementation
Backend
flowpilotto pass session ID through to creation/updates of flows