feat: progressbar component #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for moabam-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bbearcookie
changed the title
bbearcookie
reviewed
Oct 30, 2023
| @@ -0,0 +1,13 @@ | |||
| const ProgressBar = ({ progress = 0, className = '', ...props }) => ( | |||
There was a problem hiding this comment.
P2:
Input 컴포넌트 리뷰와 유사한 맥락인데요! 기본적으로 정의되어 있는 타입을 기반으로 확장성을 열어두는 방법은 어떨까요!?
추가로, 컴포넌트의 Prop 타입에 관한 컨벤션을 위해서 인터페이스를 정의해주면 좋겠네요!
interface ProgressBarProps extends React.HTMLAttributes<HTMLDivElement> {
progress?: number;
}
bbearcookie
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 이슈 번호
✅ 작업 사항
프로그래스 바 만들었습니다.
w는 기본으로 100%이고, 게이지는 progress 쓰셔서 조절 가능
밤에는 노랑 됌요
👩💻 공유 포인트 및 논의 사항