Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 아코디언 컴포넌트 수정 #185

Merged
merged 8 commits into from
Nov 22, 2023
Merged

feat: 아코디언 컴포넌트 수정 #185

merged 8 commits into from
Nov 22, 2023

Conversation

chasj0326
Copy link
Member

🧩 이슈 번호

✅ 작업 사항

1. 하나만 열리게 하는 기능 추가

아래와 같이 써주면 됩니다

<AccordionGroup singleOpen>
  <Accordion>...</Accordion>
  <Accordion>...</Accordion>
</AccordionGroup>

2. 애니메이션 보완

뭔가 버벅거리고 느리던 부분을 개선했습니다!
모바일에서도 나아져야 할텐데요..ㅠ

multianimation.mp4
singleanimation.mp4

👩‍💻 공유 포인트 및 논의 사항

갑자기 매우 뜬금없이 아코디언 화살표 방향이 저게 맞나 ..? 궁금해졌습니다!
의견 남겨주세요 .. !

@chasj0326 chasj0326 added ☁️ FE 프론트 레포지토리에서의 작업 ✨ feature 새로운 기능에 대한 작업 labels Nov 20, 2023
@chasj0326 chasj0326 added this to the 4차 스프린트 milestone Nov 20, 2023
@chasj0326 chasj0326 requested a review from nayeon-hub November 20, 2023 16:17
@chasj0326 chasj0326 self-assigned this Nov 20, 2023
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for moabam-storybook ready!

Name Link
🔨 Latest commit 1ba03f9
🔍 Latest deploy log https://app.netlify.com/sites/moabam-storybook/deploys/655d97324ec7af000839281d
😎 Deploy Preview https://deploy-preview-185--moabam-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bbearcookie bbearcookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!
오호.. 하나만 여는 기능이 추가되었군요! 👍👍
아코디언 버튼의 방향은 저도 생각해보니 현재 방향의 반대 방향이 더 익숙하게 느껴지네요..

@chasj0326 chasj0326 merged commit db70d55 into main Nov 22, 2023
@chasj0326 chasj0326 deleted the feat/#182/accordion branch November 22, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☁️ FE 프론트 레포지토리에서의 작업 ✨ feature 새로운 기능에 대한 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion 컴포넌트 수정
2 participants