Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 캘린더 구현 #173

Merged
merged 14 commits into from
Nov 22, 2023
Merged

feat: 캘린더 구현 #173

merged 14 commits into from
Nov 22, 2023

Conversation

nayeon-hub
Copy link
Contributor

@nayeon-hub nayeon-hub commented Nov 19, 2023 •
edited
Loading

🧩 이슈 번호

✅ 작업 사항

  • 캘린더 클릭 시 데이터 갱신
  • 캘린더에 현재 날짜 반영
    모아밤.webm

👩‍💻 공유 포인트 및 논의 사항

  • serverTime은 현재 하위 컴포넌트에 props으로 전달되고 있는데 세진님이 구현하시는 serverTime 로직이 완료되면, 캐싱된 값을 가지고 올 예정입니다.
  • API를 통해 받아온 serverTime에 타이머를 돌려서 자주 서버에서 받아오지 않도록 구현할 예정입니다.
  • ⚠️ 아직 섬세한 로딩 처리를 하지 않았습니다! 일단 PR을 올려놨는데... 다시 로딩 처리를 하고 PR을 올리도록 하겠습니다...!

@nayeon-hub nayeon-hub linked an issue Nov 19, 2023 that may be closed by this pull request
상세 페이지 캘린더 기능 구현 #161
Closed
2 tasks
@netlify Netlify
Copy link

netlify bot commented Nov 19, 2023 •
edited
Loading

✅ Deploy Preview for moabam-storybook ready!

Name Link
🔨 Latest commit 8991441
🔍 Latest deploy log https://app.netlify.com/sites/moabam-storybook/deploys/655e2bbcd02aec00088116e3
😎 Deploy Preview https://deploy-preview-173--moabam-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bbearcookie bbearcookie added ☁️ FE 프론트 레포지토리에서의 작업 ✨ feature 새로운 기능에 대한 작업 labels Nov 20, 2023
@bbearcookie bbearcookie added this to the 4차 스프린트 milestone Nov 20, 2023
bbearcookie
bbearcookie reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@bbearcookie bbearcookie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!! 😊

src/pages/RoomDetailPage.tsx Outdated Show resolved Hide resolved
src/core/api/options/room.ts Outdated Show resolved Hide resolved
src/RoomDetail/components/RoomCalendar.tsx Outdated Show resolved Hide resolved
src/RoomDetail/components/RoomCalendar.tsx Outdated Show resolved Hide resolved
bbearcookie
bbearcookie approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@bbearcookie bbearcookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@nayeon-hub nayeon-hub merged commit 9498858 into main Nov 22, 2023
5 checks passed
@nayeon-hub nayeon-hub deleted the feat/#161/calendar branch November 22, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbearcookie bbearcookie bbearcookie approved these changes

Assignees

@nayeon-hub nayeon-hub

Labels
☁️ FE 프론트 레포지토리에서의 작업 ✨ feature 새로운 기능에 대한 작업
Projects
None yet
Milestone
4차 스프린트
Development

Successfully merging this pull request may close these issues.

상세 페이지 캘린더 기능 구현
2 participants
@nayeon-hub @bbearcookie