feat: 로그인 기능 구현 #165
Merged
feat: 로그인 기능 구현 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for moabam-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bbearcookie
commented
Nov 18, 2023
Comment on lines
+17
to
+26
| useEffect(() => { | ||
| mutate( | ||
| { code: code ?? '' }, | ||
| { | ||
| onSuccess: ({ signUp }) => { | ||
| moveTo(signUp ? 'guide' : 'start'); | ||
| } | ||
| } | ||
| ); | ||
| }, []); |
There was a problem hiding this comment.
요 부분이 조금 마음에 걸리는데요!
이 페이지가 렌더링되면 자동으로 로그인 검증 요청 API를 쏴야하는데
로그인 검증 요청 API의 HTTP 메소드가 POST 이다보니 useQuery 를 사용하는건 적절하지 않다고 판단해서 useEffect 에서 호출했는데 어떻게 생각하시나요!? 혹은 더 좋은 방법이 있을까요?
(개발 모드에서는 두 번 호출되기 때문에 API 호출도 두 번 발생하긴 합니다..)
There was a problem hiding this comment.
저도 같은 생각입니당 POST요청이기에 mutate가 맞다고 생각돼요! 도움을 드리고 싶지만 저도 useEffect 방법밖에 생각이 나지않네요 ㅠㅠ
nayeon-hub
approved these changes
Nov 18, 2023
Comment on lines
+17
to
+26
| useEffect(() => { | ||
| mutate( | ||
| { code: code ?? '' }, | ||
| { | ||
| onSuccess: ({ signUp }) => { | ||
| moveTo(signUp ? 'guide' : 'start'); | ||
| } | ||
| } | ||
| ); | ||
| }, []); |
There was a problem hiding this comment.
저도 같은 생각입니당 POST요청이기에 mutate가 맞다고 생각돼요! 도움을 드리고 싶지만 저도 useEffect 방법밖에 생각이 나지않네요 ㅠㅠ
|
저희도 BE에서 사용하신 방법을 비슷하게 써보면 좋을 것 같아용! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 이슈 번호
✅ 작업 사항
/로 이동. 회원가입이면/guide로 이동.👩💻 공유 포인트 및 논의 사항
GOMCAM.20231117_2302460131.mp4
.env파일에 들어가야 할 내용이 몇 가지 추가되었는데, 이걸 어떻게 공유할까요?BE 팀에서는 서브 모듈을 사용하시는 것 같던데, 비슷하게 구성해볼까요?