-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: QueryErrorBoundary 컴포넌트 작성 #163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feat/#162/global-errorboundary
✅ Deploy Preview for moabam-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nayeon-hub
approved these changes
Nov 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
최고..👍🏻👍🏻
데이터 패칭 서스펜스 fallback 에 NetworkFallback 을 넣기만 하면 되네용 너무 편안 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 이슈 번호
✅ 작업 사항
QueryErrorBoundary
컴포넌트를 만들었어요.NetworkFallback
UI를 만들었어요.UnknownFallback
UI를 만들었어요.👩💻 공유 포인트 및 논의 사항
사용법
QueryErrorBoundary
컴포넌트로 래핑해요.fallback
props로 전달해요.fallback
을 위해서 사용할 수 있는 2가지의 UI 컴포넌트를 만들어뒀어요.예시
NetworkFallback
GOMCAM.20231117_1615210212.mp4
UnknownFallback