Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 쿠폰 관련 페이지 작성 #144

Merged
merged 8 commits into from
Nov 15, 2023
Merged

Feat: 쿠폰 관련 페이지 작성 #144

merged 8 commits into from
Nov 15, 2023

Conversation

chasj0326
Copy link
Member

🧩 이슈 번호

✅ 작업 사항

  • 메인페이지에 이벤트 배너를 추가했습니다
    • 배너로 충분하다고 생각되어서, 일단 팝업은 따로 하지 않았습..니다 ! 의견 있으시면 알려주세요 ~!
  • 쿠폰을 받을 수 있는 이벤트 페이지를 작성했습니다
    • 디자인 완성되는 대로 카드 UI 완성할 예정입니다 !
    • API & 토스트는 콘솔로 남겨두었습니다

@chasj0326 chasj0326 added ☁️ FE 프론트 레포지토리에서의 작업 ✨ feature 새로운 기능에 대한 작업 labels Nov 14, 2023
@chasj0326 chasj0326 added this to the 3차 스프린트 milestone Nov 14, 2023
@chasj0326 chasj0326 requested a review from nsr1349 November 14, 2023 08:19
@chasj0326 chasj0326 self-assigned this Nov 14, 2023
Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for moabam-storybook ready!

Name Link
🔨 Latest commit 7dabe3f
🔍 Latest deploy log https://app.netlify.com/sites/moabam-storybook/deploys/65545bf1c2dbfc0007961e97
😎 Deploy Preview https://deploy-preview-144--moabam-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bbearcookie bbearcookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍 고생하셨습니다~~

// couponType,
stock,
// endAt,
// point,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 사용될 필드인가보군요!!

Copy link
Member

@bbearcookie bbearcookie Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P5:
Events 디렉토리를 처음 보았을때 왠지 이벤트 핸들러가 모여있는 곳이라는 생각이 들 수도 있을 것 같아요!!
만약 더욱 세부적인 이름을 짓는다면.. 어떤게 좋을까요..? EventInfo..?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promotion은 어떨까욤?!

Copy link
Contributor

@nayeon-hub nayeon-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당~~ LGTM💛

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promotion은 어떨까욤?!

@chasj0326 chasj0326 merged commit 1db5520 into main Nov 15, 2023
@chasj0326 chasj0326 deleted the feat/#140/coupon-ui branch November 15, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☁️ FE 프론트 레포지토리에서의 작업 ✨ feature 새로운 기능에 대한 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

쿠폰 관련 페이지 작성
3 participants