feat: 방 관리 기능 완성 #137
Merged
feat: 방 관리 기능 완성 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for moabam-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nayeon-hub
approved these changes
Nov 14, 2023
Comment on lines
+68
to
+69
| onChange={(e) => setConfirmInput(e.target.value)} | ||
| /> |
There was a problem hiding this comment.
p1; onChange에 들어가는 함수는 따로 함수를 선언해서 쓰면 어떨까요?
https://www.notion.so/prgrms/FE-568228d7d8f64051b5652548944214e9?pvs=4#e81e072bdf404604862aee5f488e1de4
There was a problem hiding this comment.
엇.. 요기선 세터 함수를 호출하는 한 줄의 로직을 수행하는 것이라 구현이 드러나는 방법을 선택했어요!!
(Input 컴포넌트의 동작을 바로 확인할 수 있게 colocation 하는 느낌?)
물론 onChange 동작이 몇 줄 단위로 복잡해진다면, 다른 핸들러 함수로 빼는 것이 좋겠지만.. 한 줄 로직도 빼는것이 좋을까요!?
There was a problem hiding this comment.
아하 그것도 괜찮네요! 한 줄 일 때는 그대로 코드를 작성하는 걸로 할까요? 💡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 이슈 번호
✅ 작업 사항
👩💻 공유 포인트 및 논의 사항
방장 위임, 멤버 추방
GOMCAM.20231114_0234460059.mp4
방 삭제
GOMCAM.20231114_0238470799.mp4