Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update range concepts #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update range concepts #93

wants to merge 2 commits into from

Commits on May 13, 2020

  1. Fix empty_view 

    empty_view was accidentally privately rather than publicly inhertiting from view_interface. This has been wrong for basically the entire time that NanoRange has ever existed, and nobody (including me) has noticed until now. Hmmm.

While we've got the hood up, let's also remove the begin() and end() friends since they're no longer needed, and change size() to return a size_t since everybody loves unsigned types apparently.
    @tcbrindle
    tcbrindle committed May 13, 2020
    Configuration menu
    Copy the full SHA
    b88cfcf View commit details
    Browse the repository at this point in the history

  2. Update view concept definition to match C++20 spec 

    If you're going to write a blog post about something, you should probably make sure your own library implements it correctly, right?

This commit removes the heuristic that assumes something is a view if begin() and cbegin() return the same type, which is rather wonderful and means we no longer have to do the ugly special-casing of lots of standard library types (other than string_view, which I can live with).
    @tcbrindle
    tcbrindle committed May 13, 2020
    Configuration menu
    Copy the full SHA
    31bd0f3 View commit details
    Browse the repository at this point in the history