Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow references pane to be resized #546

Merged
merged 4 commits into from
Aug 31, 2023
Merged

allow references pane to be resized #546

merged 4 commits into from
Aug 31, 2023

Conversation

michaelficarra
Copy link
Member

No description provided.

Copy link
Contributor

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! Can you do the same for the menu pane as well?

js/menu.js Outdated Show resolved Hide resolved
@michaelficarra
Copy link
Member Author

@gibson042 Maybe some other time. Resizing the TOC doesn't seem all that useful to me.

@gibson042
Copy link
Contributor

@gibson042 Maybe some other time. Resizing the TOC doesn't seem all that useful to me.

https://tc39.es/proposal-temporal/#sec-properties-of-the-temporal-plaindatetime-prototype-object
screenshot of Temporal menu pane showing ellipses hiding Temporal.PlainDateTime.prototype property names

@michaelficarra
Copy link
Member Author

@gibson042 Yeah but there might be other solutions, like allowing horizontal scroll in the TOC

image

@gibson042
Copy link
Contributor

I'd want the pane to be resizable with or without horizontal scrolling.

@michaelficarra
Copy link
Member Author

@gibson042 That's fair. You should open an issue to track it.

@gibson042
Copy link
Contributor

Or you can add it to this PR, which doesn't have an associated issue AFAICT.

@michaelficarra
Copy link
Member Author

@gibson042 I would prefer to have this PR only address the references pane. I ask that you open an issue to track the TOC usability so that, when this PR is merged, we do not forget about the issue you raised.

@gibson042
Copy link
Contributor

#549

@bakkot bakkot merged commit b9e720f into main Aug 31, 2023
2 checks passed
@bakkot bakkot deleted the resize-references-pane branch August 31, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants