Editorial: FunctionDeclarationInstantiation cannot return ReturnCompletion #3607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because the only way to get a return completion in expression position is with a
yield
, andyield
is statically forbidden in generator formal parameters.I suspect esmeta will complain about this, because FunctionDeclarationInstantiation calls IteratorBindingInitialization to do the initialization, and that AO is also used for
let [foo] = bar
declarations, which can containyield
expressions and therefore can produce return completions. I didn't think it was worth adding an assert in FunctionDeclarationInstantiation which says that IteratorBindingInitialization cannot produce a return completion in this specific case, but I'm open to doing so if we can do it without making the algorithm too awkward.This imprecision is exposed by #3606 failing esmeta's typechecks. It should pass if rebased on this (I think).