This repository has been archived by the owner on Feb 4, 2024. It is now read-only.
Fix handling of interrupted/canceled permission request #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is a permission dialog present and we try to request more permissions the second request returns immediately empty results. We need to propagate this failure to observers while making sure that the previous permission request observers remain untouched.
|
Do not merge yet, I've encountered some ANRs. |
We need to mark a pending request canceled if we're not going to submit it to framework.
|
Ok, go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to fix and supersede #218.
See also #264 which describes solved issues.