Fix logging of failure on Customer removal

Plugin/Customer/Model/ResourceModel/CustomerRepository.php

@@ -6,6 +6,8 @@
 use Magento\Framework\Exception\LocalizedException;
 use Taxjar\SalesTax\Model\Client;
 use Taxjar\SalesTax\Model\ClientFactory;
+use Taxjar\SalesTax\Model\Configuration;
+use Taxjar\SalesTax\Model\Logger;
 
 class CustomerRepository
 {
@@ -14,12 +16,19 @@ class CustomerRepository
      */
     private $clientFactory;
 
+    /**
+     * @var Logger $logger
+     */
+    protected $logger;
+
     /**
      * @param ClientFactory $clientFactory
+     * @param Logger $logger
      */
-    public function __construct(ClientFactory $clientFactory)
+    public function __construct(ClientFactory $clientFactory, Logger $logger)
     {
         $this->clientFactory = $clientFactory;
+        $this->logger = $logger;
     }
 
     /**
@@ -38,7 +47,7 @@ public function beforeDeleteById(
             $this->getClient()->deleteResource('customers', $customerId);
         } catch (LocalizedException $e) {
             $message = 'Could not delete customer #' . $customerId . ": " . $e->getMessage();
-            $this->logger->log($message, 'error');
+            $this->getLogger()->log($message, 'error');
         }
 
         return $customerId;
@@ -55,4 +64,16 @@ private function getClient(): Client
         $client->showResponseErrors(true);
         return $client;
     }
+
+    /**
+     * Returns our Logger instance configured to write to the TaxJar customer log.
+     *
+     * @return Logger
+     */
+    private function getLogger(): Logger
+    {
+        $logger = $this->logger;
+        $logger->setFilename(Configuration::TAXJAR_CUSTOMER_LOG);
+        return $logger;
+    }
 }

Test/Unit/Plugin/Customer/Model/ResourceModel/CustomerRepositoryInterfaceTest.php

@@ -3,9 +3,12 @@
 namespace Taxjar\SalesTax\Test\Unit\Plugin\Customer\Model\ResourceModel;
 
 use Magento\Customer\Api\CustomerRepositoryInterface;
+use Magento\Framework\Exception\LocalizedException;
 use PHPUnit\Framework\MockObject\MockObject;
 use Taxjar\SalesTax\Model\Client;
 use Taxjar\SalesTax\Model\ClientFactory;
+use Taxjar\SalesTax\Model\Configuration;
+use Taxjar\SalesTax\Model\Logger;
 use Taxjar\SalesTax\Plugin\Customer\Model\ResourceModel\CustomerRepository;
 use Taxjar\SalesTax\Test\Unit\UnitTestCase;
 
@@ -21,13 +24,22 @@ class CustomerRepositoryInterfaceTest extends UnitTestCase
      */
     private $clientFactoryMock;
 
+    /**
+     * @var MockObject|Logger
+     */
+    private $loggerMock;
+
     protected function setUp(): void
     {
         parent::setUp();
 
         $this->clientFactoryMock = $this->getMockBuilder(ClientFactory::class)
             ->disableOriginalConstructor()
             ->getMock();
+
+        $this->loggerMock = $this->getMockBuilder(Logger::class)
+            ->disableOriginalConstructor()
+            ->getMock();
     }
 
     public function testBeforeDeleteById()
@@ -54,10 +66,38 @@ public function testBeforeDeleteById()
         static::assertSame(123, $this->sut->beforeDeleteById($subjectMock, 123));
     }
 
+    public function testBeforeDeleteByIdFailureLogsError()
+    {
+        $expectedMessage = 'Could not delete customer #123: Failed to initialize client';
+
+        $mockException = new LocalizedException(__('Failed to initialize client'));
+
+        $subjectMock = $this->getMockBuilder(CustomerRepositoryInterface::class)
+            ->disableOriginalConstructor()
+            ->getMockForAbstractClass();
+
+        $this->clientFactoryMock->expects(static::once())
+            ->method('create')
+            ->willThrowException($mockException);
+
+        $this->loggerMock->expects(static::once())
+            ->method('setFilename')
+            ->with(Configuration::TAXJAR_CUSTOMER_LOG);
+
+        $this->loggerMock->expects(static::once())
+            ->method('log')
+            ->with($expectedMessage);
+
+        $this->setExpectations();
+
+        static::assertSame(123, $this->sut->beforeDeleteById($subjectMock, 123));
+    }
+
     protected function setExpectations()
     {
         $this->sut = new CustomerRepository(
-            $this->clientFactoryMock
+            $this->clientFactoryMock,
+            $this->loggerMock
         );
     }
 }