fix: set WebKitGTK WebsiteDataManager's base_cache_directory #1547
Conversation
If that was the case, the `os` property would be re-set with the new value for the cache directory. Also, I mis-swapped `data_directory` and `cache_directory` in `WebContextImpl::new`'s call.
|
maybe we should just derive the cache dir from the data dir even if not 100% correct? That would match the behavior on Windows at least. |
Co-authored-by: Fabian-Lars <[email protected]>
This reverts commit 74312c0.
This reverts commit 5bfd042.
This reverts commit 29030e1.
sehnryr
changed the title
cache_directory to WebContext::new
Package Changes Through 055b954There are 1 changes which include wry with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| let mut context_builder = WebContext::builder(); | ||
| if let Some(data_directory) = data_directory { | ||
| let data_manager = WebsiteDataManager::builder() | ||
| .base_cache_directory(data_directory.to_string_lossy()) |
There was a problem hiding this comment.
i can't remember what exactly the cache looks like on windows, do you think it makes sense to create a cache subdir like we do for the cookies below?
There was a problem hiding this comment.
by default webkitgtk put the cache in the same dir as the data, so I don't think it would be wrong to set it that way as well when providing a custom data path
2 participants
Set
WebsiteDataManagerBuilder::base_cache_directorywith the same path asbase_data_directory.This change allows the cache directory to be changed instead of using the default one from WebKitGTK.