fix(windows): nsis failed to resolve resources with $ in their name, closes #9657
#9659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contributions. I did a bit of experiments and seems like only the input to |
|
@amrbashir |
amrbashir
requested changes
May 8, 2024
amrbashir
reviewed
May 8, 2024
amrbashir
approved these changes
May 8, 2024
amrbashir
changed the title
$ in their name. closes #9657$ in their name, closes #9657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registering a global escape function that replaces
$with$$in Handlebars causes the build step to fail when resources contain$in their names, because NSIS commands likeFile /acannot resolve the escaped paths. #9657I've added a helper that unescapes
$$back to$and modified the corresponding resource expression ininstaller.nsito use this helper.If there are better solutions, I'd be happy to implement them.