Skip to content

Added result parsing on return. #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2025
Merged

Added result parsing on return. #415

merged 4 commits into from
Apr 18, 2025

Conversation

s3rius
Copy link
Member

@s3rius s3rius commented Mar 2, 2025

This patch adds result parsing when got serialized result from result backend. It requires type annotation for that. Parsing is laxed and if failed, result will be returned as is.

Referenced issue: taskiq-python/taskiq-redis#75

@jegork, this issues appears much deeper into core than I initially thought. Fixing it breaks some backward compatibility.

@s3rius s3rius requested a review from chandr-andr March 2, 2025 20:23
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.98%. Comparing base (a89cac1) to head (ba55f43).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage   77.80%   77.98%   +0.18%     
==========================================
  Files          62       62              
  Lines        1933     1949      +16     
==========================================
+ Hits         1504     1520      +16     
  Misses        429      429              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s3rius s3rius merged commit 23422c7 into master Apr 18, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant