Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve load behavior #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chuckdries
Copy link

@chuckdries chuckdries commented Jun 18, 2020

  • renders an empty box immediately, so hopefully it's less jarring when the content loads
  • fetches the colors and emojis in parallel (instead of waiting for emojis to finish before requesting colors)

This will be a merge conflict with my other PR. I originally made all these changes together as they're both changes that I wanted for myself, but I split them apart for PRs. I'll handle rebasing whichever goes in second if you want both of them.

Thanks for this thing by the way, it's really neat and I was just about to have to build something similar for myself :)

@tarptaeya
Copy link
Owner

Instead of showing just border, I think that adding Loading user:repo text will give a feedback that the content is being loaded. Also pease create another pr for fetching emojis and colors in parallel (one pr per feature).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants