Skip to content

Renames parse_selected_atoms -> parse_selected_elements #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Sonu0305
Copy link

@Sonu0305 Sonu0305 commented Apr 1, 2025

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.

Closes #444

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link
Contributor

github-actions bot commented Apr 1, 2025

*beep* *bop*
Hi human,
I ran ruff on the latest commit (263f58d).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

14	F401	unused-import

Complete output(might be large):

carsus/io/lanlads/base.py:6:25: F401 [*] `carsus.util.parse_selected_elements` imported but unused
carsus/io/lanlads/base.py:7:33: F401 [*] `carsus.util.helpers.SYMBOL2ATOMIC_NUMBER` imported but unused
carsus/io/lanlads/base.py:7:55: F401 [*] `carsus.util.helpers.ATOMIC_NUMBER2SYMBOL` imported but unused
carsus/util/__init__.py:7:9: F401 `carsus.util.helpers.convert_camel2snake` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
carsus/util/__init__.py:8:9: F401 `carsus.util.helpers.convert_atomic_number2symbol` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
carsus/util/__init__.py:9:9: F401 `carsus.util.helpers.convert_symbol2atomic_number` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
carsus/util/__init__.py:10:9: F401 `carsus.util.helpers.convert_wavelength_air2vacuum` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
carsus/util/__init__.py:11:9: F401 `carsus.util.helpers.convert_wavelength_vacuum2air` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
carsus/util/__init__.py:12:9: F401 `carsus.util.helpers.get_data_path` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
carsus/util/__init__.py:12:24: F401 `carsus.util.helpers.query_columns` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
carsus/util/__init__.py:14:34: F401 `carsus.util.selected.parse_selected_elements` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
carsus/util/__init__.py:14:59: F401 `carsus.util.selected.parse_selected_species` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
carsus/util/__init__.py:16:30: F401 `carsus.util.hash.serialize_pandas_object` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
carsus/util/__init__.py:16:55: F401 `carsus.util.hash.hash_pandas_object` imported but unused; consider removing, adding to `__all__`, or using a redundant alias
Found 14 errors.
[*] 3 fixable with the `--fix` option.

@andrewfullard
Copy link
Contributor

@atharva-2001 the check failures are weird- is this an overall carsus actions issue?

@Sonu0305
Copy link
Author

Sonu0305 commented Apr 1, 2025

@andrewfullard ,
Regarding failing tests/osx-64:
I found the out the issue, the wget command in the actions accesses a faulty URL of the osx arm lock file.

This link is faulty,
Link: https://raw.githubusercontent.com/tardis-sn/tardis/master/conda-osx-64.lock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename parse_selected_atoms -> parse_selected_elements
2 participants