set default params for quick test and add scenario5 #130
+253
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (5)
- scripts/tsdbComp/full_cycle_minitest_loading.sh: Language not supported
- scripts/tsdbComp/full_cycle_minitest_query_loading.sh: Language not supported
- scripts/tsdbComp/install_env.sh: Language not supported
- scripts/tsdbComp/load_all_cases.sh: Language not supported
- scripts/tsdbComp/tsbs_test.sh: Language not supported
Comments suppressed due to low confidence (1)
scripts/tsdbComp/load_report.py:175
- Ensure that 'figure' is correctly imported from matplotlib.pyplot or replace it with 'plt.figure' so that the code is consistent with later calls to plt.subplot, plt.savefig, and plt.close.
fig = figure(figsize=(12, 10), dpi=300, layout='constrained')
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new disk usage chart mode for quick test visualizations and adds support for an authentication token for InfluxDB 3.0 across several components.
- Updated command-line arguments and chart generation code in the Python reporting script to support a new "diskusage" mode.
- Enhanced Influx target and query/load components in Go to handle an additional "auth-token" parameter, and adjusted HTTP client and request handling accordingly.
- Modified the database creator to include an authentication header, although the header format is inconsistent with other components.
Reviewed Changes
Copilot reviewed 8 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/tsdbComp/load_report.py | Added diskusage chart creation logic and updated the --mode argument options. |
| pkg/targets/influx3/implemented_target.go | Introduced a new flag for authentication token. |
| cmd/tsbs_run_queries_influx3/main.go | Added authToken handling for queries via a new flag. |
| cmd/tsbs_run_queries_influx3/http_client.go | Updated HTTP client to include authorization header. |
| cmd/tsbs_load_influx3/main.go | Enabled authToken parsing and validation for load operations. |
| cmd/tsbs_load_influx3/http_writer_test.go | Adjusted tests to accommodate the new initializeReq signature. |
| cmd/tsbs_load_influx3/http_writer.go | Modified request initialization to incorporate the auth token parameter. |
| cmd/tsbs_load_influx3/creator.go | Updated database creator HTTP requests to include authentication in headers. |
Files not reviewed (9)
- scripts/tsdbComp/common.sh: Language not supported
- scripts/tsdbComp/full_cycle_minitest_loading.sh: Language not supported
- scripts/tsdbComp/full_cycle_minitest_query.sh: Language not supported
- scripts/tsdbComp/full_cycle_minitest_query_loading.sh: Language not supported
- scripts/tsdbComp/install_env.sh: Language not supported
- scripts/tsdbComp/load_all_cases.sh: Language not supported
- scripts/tsdbComp/query_test.sh: Language not supported
- scripts/tsdbComp/test.ini: Language not supported
- scripts/tsdbComp/tsbs_test.sh: Language not supported
| textcoords="offset points", | ||
| ha='center', va='bottom') | ||
|
|
||
| ax.set_ylabel('(MB))') |
There was a problem hiding this comment.
There is an extra closing parenthesis in the Y-axis label. Consider changing '(MB))' to '(MB)'.
Suggested change
| ax.set_ylabel('(MB))') | |
| ax.set_ylabel('(MB)') |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
cmd/tsbs_load_influx3/creator.go
Outdated
| @@ -100,6 +106,7 @@ func (d *dbCreator) CreateDB(dbName string) error { | |||
|
|
|||
| // Set the content type to application/json | |||
| req.Header.Set("Content-Type", "application/json") | |||
| req.Header.Set("Authorization", "Bearer "+authToken) | |||
There was a problem hiding this comment.
The authentication header uses the 'Bearer' prefix here, which is inconsistent with the 'Token' prefix used elsewhere. Standardize the auth header format across the codebase.
Suggested change
| req.Header.Set("Authorization", "Bearer "+authToken) | |
| req.Header.Set("Authorization", "Token "+authToken) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please briefly describe the code changes in this pull request.
Jira: https://jira.taosdata.com:18080/browse/TD-
Checklist
Please check the items in the checklist if applicable.