enh: operator input check #28839
Merged
enh: operator input check #28839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facetosea
changed the title
dapan1121
reviewed
Nov 26, 2024
source/libs/executor/inc/operator.h
Outdated
| do { \ | ||
| if (!(c)) { \ | ||
| qError("function:%s condition failed, Line:%d", __FUNCTION__, __LINE__); \ | ||
| return TSDB_CODE_APP_ERROR; \ |
| @@ -1003,11 +1005,14 @@ static int32_t hashPartitionNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) | |||
| return TSDB_CODE_SUCCESS; | |||
| } | |||
|
|
|||
| CHECK_CONDITION_FAILED(pOperator->info != NULL); | |||
There was a problem hiding this comment.
这一大类都属于参数校验的范围，不属于逻辑正确性校验的范围，如果要做也应该是在create operator时做，每次在这里校验意义不大
dapan1121
approved these changes
Nov 28, 2024
guanshengliang
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist