Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:Unmaximizes the window #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

planpoh
Copy link

@planpoh planpoh commented Apr 4, 2019

https://electronjs.org/docs/api/browser-window
Unmaximizes the window should call unmaximize() instead of restore().

@a-sync
Copy link
Collaborator

a-sync commented Apr 4, 2019

Hey, first of all thanks!
I agree its confusing, but the api doesn't mirror the electron api exactly. If you check the readme it does what it says:

Maximizes the window. Restores if already maximized.

Since this changes the api, i wont merge it, but ill gladly add a version which adds the unmaximize() method and leaves the logic of maximize() according to the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants