Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Catwalks Desyncing/Ghost Blocking #94

Open
wants to merge 10 commits into
base: 1.19-forge
Choose a base branch
from

Conversation

nightmarishblue
Copy link

@nightmarishblue nightmarishblue commented Aug 24, 2023

Fixed the desyncs that occured due to the CatWalkBlock's getStateForPlacement() override, moving the logic into CatwalkBlockItem's place() method.
Catwalks placed on the upper half of a block now place in the right 1-block offset instead of producing desyncs (I'll test this more rigorously on a dedicated server). If the block above the player's cursor is occupied, it will place as normal. I don't know if NBT data is the cleanest way of doing this but I couldn't think of any other way to move the data between the item's place() and the block's getStateForPlacement().

Oh, right. This resolves #77 and possibly #84, as well as the closed #54.

@drakray
Copy link

drakray commented Dec 12, 2023

Hi there, is there plan to implement this, or something similar?
I got the desync bug on my dedicated server, and more than that, just mouse-hover an iron catwalk when having something in my main hand make the item in the main hand "disappear"(only visually, opening another inventory or refreshing make the stuff appear again)
Trying to place an Iron Catwalk using Create Easy-Placement put the catwalk on top of one another, instead of side by side(or both, I can't remember right now)

CreateDeco 2.0.0 for 1.20.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants