Fixed Catwalks Desyncing/Ghost Blocking #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the desyncs that occured due to the
CatWalkBlock
'sgetStateForPlacement()
override, moving the logic intoCatwalkBlockItem
'splace()
method.Catwalks placed on the upper half of a block now place in the right 1-block offset instead of producing desyncs (I'll test this more rigorously on a dedicated server). If the block above the player's cursor is occupied, it will place as normal. I don't know if NBT data is the cleanest way of doing this but I couldn't think of any other way to move the data between the item's
place()
and the block'sgetStateForPlacement()
.Oh, right. This resolves #77 and possibly #84, as well as the closed #54.