Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cage lamp rotation (#167) #168

Open
wants to merge 1 commit into
base: 1.20-main
Choose a base branch
from

Conversation

stop-x13
Copy link

@stop-x13 stop-x13 commented Jul 1, 2024

Should fix the issue #167 .

@SopsyHallow
Copy link

Does this only fix the lamp, or does it fix all oriented blocks? (like catwalk stairs, catwalk railings, support blocks etc)

i know your issue was specifically with the cage lamp but it seems to be an issue with every/most blocks that has orientations

@stop-x13
Copy link
Author

It only fixes the cage lamp block as this appeared to me first when I built my crane attached with a lamp. The only addition is the rotate() method of the cage lamp block. I have not tried other blocks yet, but normal stairs do rotate normally.

@SopsyHallow
Copy link

railing and catwalk stairs had/have the same issue as the lamp does, and personally i presume that all orientation based blocks inside this mod (not outside of the mod, other orientational blocks work fine with create) have the same core problem as the lamp did

@stop-x13
Copy link
Author

railing and catwalk stairs had/have the same issue as the lamp does, and personally i presume that all orientation based blocks inside this mod (not outside of the mod, other orientational blocks work fine with create) have the same core problem as the lamp did

I think so. I might look into that when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants