Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore generated assets in the repo and fix CI #153

Open
wants to merge 3 commits into
base: 1.20-main
Choose a base branch
from

Conversation

drewcassidy
Copy link

The generated assets in the git repo are all entirely generated by the java files. This seems to be confusing some people and makes it possible for the data to get out of sync with the source

Removing the generated files means that building requires running datagen, which is a pretty quick process. I've also added it as a step to the CI, so the datagen also gets tested

I also fixed the CI not uploading the correct jars :)

@MrRedstoneToGo
Copy link

MrRedstoneToGo commented Apr 27, 2024

So, you deleted (or had them deleted) the files in the src/generated folder on github so that there are no misunderstandings again, right? So, as far as I understand it, many recipes are only generated when you run the mod in Minecraft. And what does "CI" mean?

@Peruibeloko
Copy link

@MrRedstoneToGo The recipes are still generated, but not when the mod is run in game, its part of the process used to create the .jar file of the mod itself

CI stands for Continuous Integration, its a software development process in which updates to the source code automatically generate a build, instead of manually :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants