Fix matching files when config is not in the workspace root #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
thecrypticace
force-pushed
the
feat/config-matching-not-in-root
branch
from
f626cd4 to
81c2cae
Compare
RobinMalfait
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In IntelliSense we have this special behavior where if we only detect a single config in a workspace then that config will cover files opened in the entire workspace. We broke this accidentally in v0.14.16 because we made sure document selectors were re-calculated correctly for v4 projects files. With how things are structured/shared this setup is the same for v3 and v4 and we accidentally wiped out the "root" selector we'd add to the project if it was the only one in a given workspace folder.
So this isn't usually a problem but definitely can be if:
This should hopefully fix any project matching issues people have had that broke from v0.14.17 and later.
Fixes #1404 (and maybe #1377)