Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onboarding-wizard): adding support for ovhcloud #1226

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Kolawole99
Copy link
Collaborator

@Kolawole99 Kolawole99 commented Nov 24, 2023

Problem

We intend to add OVHCloud support to the Onboarding Wizard.

As of now, other cloud providers are supported and can be configured through config.toml or the Onboarding Wizard, OVHCloud can only be configured through the config.toml file.

This handles GitHub issue #1213
This handles Linear ticket https://linear.app/tailwarden/issue/KOM-40

Solution

I added support for OVHCloud to the onboarding Wizard.
Screenshot 2023-11-24 at 11 15 12 AM
Screenshot 2023-11-24 at 11 15 18 AM
Screenshot 2023-11-24 at 11 15 21 AM

Changes Made

  • I added an OVHCloud form that will be rendered by the OVH Cloud page and will allow users to submit the credentials to connect their OVHCloud account.
  • I added the OVHCloud Cloud Accounts Page that the file path routing system of Next will automatically render.
  • I maintained the existing submit method and created a new OVHCloud interface to handle the input form data.

How to Test

Run a fresh install of Komiser which will trigger the Onboarding Wizard. Select OVH in the cloud account and click next, this should automatically route you to the OVH page to configure your credentials and submit to connect your OVH cloud accounts.

You can refer to the Screenshots above for a detailed demo of the process

Screenshots

[Include screenshots, if relevant, to help reviewers understand the changes you made.]

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

@scraly
Copy link

scraly commented Dec 6, 2023

Hi,
what is missing? :)

Copy link
Collaborator

@AvineshTripathi AvineshTripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey folks apologies for delayed reviews I was caught up in something and the team is focussed in fixing the onboarding-wizard bug (we are still fixing).

Thanks @Kolawole99 for the PR. I have some minor nits. Maybe either we should remove the sublabels or add something else. Also add a space in OVHCloud dashboard/utils/providerHelper.ts

@mlabouardy
Copy link
Collaborator

Hey folks apologies for delayed reviews I was caught up in something and the team is focussed in fixing the onboarding-wizard bug (we are still fixing).

Thanks @Kolawole99 for the PR. I have some minor nits. Maybe either we should remove the sublabels or add something else. Also add a space in OVHCloud dashboard/utils/providerHelper.ts

@Kolawole99 any update? do you need help?

@Kolawole99
Copy link
Collaborator Author

Hey folks apologies for delayed reviews I was caught up in something and the team is focussed in fixing the onboarding-wizard bug (we are still fixing).

Thanks @Kolawole99 for the PR. I have some minor nits. Maybe either we should remove the sublabels or add something else. Also add a space in OVHCloud dashboard/utils/providerHelper.ts

@AvineshTripathi I would take a look at this, must have got lost in the notifications last year.

@mlabouardy

@Kolawole99
Copy link
Collaborator Author

@AvineshTripathi just for clarification that I got your nit correctly, the space should be in line

label: 'OVHcloud',

Also, can you clarify the issue with the sublabels

@AvineshTripathi
Copy link
Collaborator

for sublables i meant the text below the title like Endpoints etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants