Rename DataType methods as_f64 as_i64 into as_float as_int

tafia · Dec 19, 2023 · 2e376ed · 2e376ed
1 parent ad57593
commit 2e376ed
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -65,7 +65,7 @@ where
     D: serde::Deserializer<'de>,
 {
     let data_type = calamine::DataType::deserialize(deserializer)?;
-    if let Some(float) = data_type.as_f64() {
+    if let Some(float) = data_type.as_float() {
         Ok(Some(float))
     } else {
         Ok(None)
@@ -85,7 +85,6 @@ fn main() ->  Result<(), Box<dyn std::error::Error>> {
   }
 ```
 
-
 ### Reader: Simple
 
 ```rust
@@ -160,7 +159,7 @@ for s in sheets {
 
 ## Features
 
-- `dates`: Add date related fn to `DataType`. 
+- `dates`: Add date related fn to `DataType`.
 - `picture`: Extract picture data.
 
 ### Others

diff --git a/src/datatype.rs b/src/datatype.rs
@@ -105,7 +105,7 @@ impl DataType {
         }
     }
     /// Try converting data type into an int
-    pub fn as_i64(&self) -> Option<i64> {
+    pub fn as_int(&self) -> Option<i64> {
         match self {
             DataType::Int(v) => Some(*v),
             DataType::Float(v) => Some(*v as i64),
@@ -114,7 +114,7 @@ impl DataType {
         }
     }
     /// Try converting data type into a float
-    pub fn as_f64(&self) -> Option<f64> {
+    pub fn as_float(&self) -> Option<f64> {
         match self {
             DataType::Int(v) => Some(*v as f64),
             DataType::Float(v) => Some(*v),