test: deduplicate pytest params for problem 1484

tablexpr · Jan 28, 2025 · 313d966 · 313d966
1 parent 656924e
commit 313d966
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 76 deletions.
diff --git a/tests/test_datafusion.py b/tests/test_datafusion.py
@@ -152,44 +152,7 @@ def test_problem_1378(input_data_1, input_data_2, expected_data):
 
 @pytest.mark.parametrize(
     "input_data, expected_data",
-    [
-        pytest.param(
-            {
-                "sell_date": [
-                    datetime(2020, 5, 30),
-                    datetime(2020, 6, 1),
-                    datetime(2020, 6, 2),
-                    datetime(2020, 5, 30),
-                    datetime(2020, 6, 1),
-                    datetime(2020, 6, 2),
-                    datetime(2020, 5, 30),
-                ],
-                "product": [
-                    "Headphone",
-                    "Pencil",
-                    "Mask",
-                    "Basketball",
-                    "Bible",
-                    "Mask",
-                    "T-Shirt",
-                ],
-            },
-            {
-                "sell_date": [
-                    datetime(2020, 5, 30),
-                    datetime(2020, 6, 1),
-                    datetime(2020, 6, 2),
-                ],
-                "num_sold": [3, 2, 1],
-                "products": [
-                    "Basketball,Headphone,T-Shirt",
-                    "Bible,Pencil",
-                    "Mask",
-                ],
-            },
-            id="happy_path",
-        ),
-    ],
+    PARAMS_PROBLEM_1484,
 )
 def test_problem_1484(input_data, expected_data):
     table = pa.Table.from_pydict(input_data)

diff --git a/tests/test_pandas.py b/tests/test_pandas.py
@@ -642,44 +642,7 @@ def test_problem_1378(input_data_1, input_data_2, expected_data):
 
 @pytest.mark.parametrize(
     "input_data, expected_data",
-    [
-        pytest.param(
-            {
-                "sell_date": [
-                    datetime(2020, 5, 30),
-                    datetime(2020, 6, 1),
-                    datetime(2020, 6, 2),
-                    datetime(2020, 5, 30),
-                    datetime(2020, 6, 1),
-                    datetime(2020, 6, 2),
-                    datetime(2020, 5, 30),
-                ],
-                "product": [
-                    "Headphone",
-                    "Pencil",
-                    "Mask",
-                    "Basketball",
-                    "Bible",
-                    "Mask",
-                    "T-Shirt",
-                ],
-            },
-            {
-                "sell_date": [
-                    datetime(2020, 5, 30),
-                    datetime(2020, 6, 1),
-                    datetime(2020, 6, 2),
-                ],
-                "num_sold": [3, 2, 1],
-                "products": [
-                    "Basketball,Headphone,T-Shirt",
-                    "Bible,Pencil",
-                    "Mask",
-                ],
-            },
-            id="happy_path",
-        ),
-    ],
+    PARAMS_PROBLEM_1484,
 )
 def test_problem_1484(input_data, expected_data):
     table = pd.DataFrame(input_data)

diff --git a/tests/test_problem_params.py b/tests/test_problem_params.py
@@ -1319,6 +1319,45 @@
 ]
 
 
+PARAMS_PROBLEM_1484 = [
+    pytest.param(
+        {
+            "sell_date": [
+                datetime(2020, 5, 30),
+                datetime(2020, 6, 1),
+                datetime(2020, 6, 2),
+                datetime(2020, 5, 30),
+                datetime(2020, 6, 1),
+                datetime(2020, 6, 2),
+                datetime(2020, 5, 30),
+            ],
+            "product": [
+                "Headphone",
+                "Pencil",
+                "Mask",
+                "Basketball",
+                "Bible",
+                "Mask",
+                "T-Shirt",
+            ],
+        },
+        {
+            "sell_date": [
+                datetime(2020, 5, 30),
+                datetime(2020, 6, 1),
+                datetime(2020, 6, 2),
+            ],
+            "num_sold": [3, 2, 1],
+            "products": [
+                "Basketball,Headphone,T-Shirt",
+                "Bible,Pencil",
+                "Mask",
+            ],
+        },
+        id="happy_path",
+    ),
+]
+
 PARAMS_PROBLEM_1517 = [
     pytest.param(
         {