-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add docker compose #2049
base: main
Are you sure you want to change the base?
feat: Add docker compose #2049
Conversation
for easier copy in next commit, or more files in the future
use `docker compose up -d` in start-database.sh
🦋 Changeset detectedLatest commit: 8d2ce67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@NathanaelRea is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
Also I noticed that currently the mysql https://github.com/t3-oss/create-t3-app/blob/main/cli/template/extras/start-database/mysql.sh#L18 Edit: I realized a couple things to simplify this change and the container overall. Let me know if I should make them.
services:
db:
image: postgres:latest
container_name: "${DB_NAME?}-postgres"
|
Closes #
✅ Checklist
Changelog
Add
docker-compose.yml
file for postgres and mysql database options.start-database.sh
now exports the needed environment variables and callsdocker compose up -d
. This serves as a more observable example, and is more extensible if the user wants to add services.Moves forward #1927 because the user can now run
docker compose up -d
, but not complete because would probably want to:./start-databse.sh
into an entrypoint for aDockerfile
(one line difference - setting container name)generate db password
into cli after choosing db provider to simplifystart-database.yml
Screenshots
[Screenshots]
💯