test adding lint and formating check to e2e tests

t3-oss · Jan 15, 2025 · e84958e · e84958e
1 parent 897ae87
commit e84958e
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 5 deletions.
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
@@ -34,6 +34,7 @@ jobs:
         appRouter: ["true", "false"]
         drizzle: ["true", "false"]
         dbType: ["planetscale", "sqlite", "mysql", "postgres"]
+        # linter: ["eslint", "biome"]
 
     name: "Build and Start T3 App ${{ matrix.trpc }}-${{ matrix.tailwind }}-${{ matrix.nextAuth }}-${{ matrix.prisma }}-${{ matrix.drizzle}}-${{ matrix.appRouter }}-${{ matrix.dbType }}"
     steps:
@@ -66,6 +67,9 @@ jobs:
           AUTH_DISCORD_SECRET: baz
           SKIP_ENV_VALIDATION: true
 
+      # WIP ensure that generated app passes formatting and linting checks
+      - run: pnpm format:check && pnpm check
+
   build-t3-app-with-bun:
     runs-on: ubuntu-latest
 

diff --git a/cli/src/helpers/format.ts b/cli/src/helpers/format.ts
@@ -0,0 +1,8 @@
+import { execa } from "execa";
+
+import { logger } from "~/utils/logger.js";
+
+//! WIP not implemented yet
+
+// Ensures that generated project is tidy after init according to selected formatter
+export const formatProject = (eslint: boolean, biome: boolean) => {};
diff --git a/cli/src/index.ts b/cli/src/index.ts
@@ -38,7 +38,7 @@ const main = async () => {
   const {
     appName,
     packages,
-    flags: { noGit, noInstall, importAlias, appRouter },
+    flags: { noGit, noInstall, importAlias, appRouter, eslint },
     databaseProvider,
   } = await runCli();
 
@@ -89,6 +89,8 @@ const main = async () => {
     await initializeGit(projectDir);
   }
 
+  // TODO run format command
+
   await logNextSteps({
     projectName: appDir,
     packages: usePackages,

diff --git a/cli/src/installers/biome.ts b/cli/src/installers/biome.ts
@@ -22,9 +22,9 @@ export const biomeInstaller: Installer = ({ projectDir }) => {
   addPackageScript({
     projectDir,
     scripts: {
-      "format:unsafe": "biome check --write --unsafe .",
-      "format:write": "biome check --write .",
-      "format:check": "biome check .",
+      "check:unsafe": "biome check --write --unsafe .",
+      "check:write": "biome check --write .",
+      check: "biome check .",
     },
   });
 };
diff --git a/cli/template/extras/src/trpc/react.tsx b/cli/template/extras/src/trpc/react.tsx
@@ -17,7 +17,10 @@ const getQueryClient = () => {
     return createQueryClient();
   }
   // Browser: use singleton pattern to keep the same query client
-  return (clientQueryClientSingleton ??= createQueryClient());
+  if (!clientQueryClientSingleton) {
+    clientQueryClientSingleton = createQueryClient();
+  }
+  return clientQueryClientSingleton;
 };
 
 export const api = createTRPCReact<AppRouter>();