Fix duplicate sessions

szmarczak · Nov 10, 2023 · f1a1776 · f1a1776
1 parent 03bbcd2
commit f1a1776
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/source/agent.js b/source/agent.js
@@ -15,8 +15,8 @@ const kGracefullyClosing = Symbol('gracefullyClosing');
 const kLength = Symbol('length');
 
 const nameKeys = [
- // Not an Agent option actually
- 'createConnection',
+ // Theoretically we could depend on `createConnection`, but practically this results in a bug.
+ // `createConnection` gets replaced when the session gets reused, so this would result in a duplicate session.
 
  // `http2.connect()` options
  'maxDeflateDynamicTableSize',