Avoid creating flush ByteBuf/Segment when not necessary. #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently every call to update calls flush which creates a new flush buffer and segment. Even when there is no work required to be done.
ByteBufAllocator.ioBuffer is a fairly expensive call to call every update.
Unless I am doing something wrong, Kcp#check will schedule a work duration (100ms by default) not necessarily when the next "action" is required. This might be better handled by changing Kcp#check?