make cimbar.exe work properly #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntain mode codec works correctly.
sz3
reviewed
Mar 2, 2025
src/third_party_lib/fmt/format.h
Outdated
| @@ -1453,7 +1453,11 @@ template <typename WChar, typename Buffer = memory_buffer> class to_utf8 { | |||
| ++p; | |||
| if (p == s.end() || (c & 0xfc00) != 0xd800 || (*p & 0xfc00) != 0xdc00) { | |||
| if (policy == to_utf8_error_policy::abort) return false; | |||
| #ifdef _WIN32 | |||
| buf.append(string_view("\xef\xbf\xbd")); | |||
There was a problem hiding this comment.
Sadly, this is not a change we can make here. Everything in third_party_lib is vendored from an upstream repo -- i.e. this file is fmt 10.1.0 verbatim.
It's worth noting that we're overdue for a dependency bump here (https://github.com/fmtlib/fmt is up to 11.1.4), but I'm not sure if that'll make this change or harder.
There was a problem hiding this comment.
Got it, I have undone the non-conforming modifications. This issue exists only in fmt version 10.1.0.
|
Thanks for taking a swing at this -- not sure I can take it as is because of the fmtlib change, but it's useful regardless. |
sz3
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix compilation errors in the MSVC c++ environment and ensure the fountain mode codec works correctly.